Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/ui/cocoa/history_menu_bridge.mm

Issue 694843002: Remove NOTIFICATION_HISTORY_URLS_MODIFIED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/history_menu_bridge.mm
diff --git a/chrome/browser/ui/cocoa/history_menu_bridge.mm b/chrome/browser/ui/cocoa/history_menu_bridge.mm
index 50456dc3b42fc303f6d71cf757fb6fb7bc5d42a7..f1095a764614bb4d99d27543c830db8abc1aef14 100644
--- a/chrome/browser/ui/cocoa/history_menu_bridge.mm
+++ b/chrome/browser/ui/cocoa/history_menu_bridge.mm
@@ -115,8 +115,6 @@ HistoryMenuBridge::~HistoryMenuBridge() {
// Unregister ourselves as observers and notifications.
DCHECK(profile_);
if (history_service_) {
- registrar_.Remove(this, chrome::NOTIFICATION_HISTORY_URLS_MODIFIED,
- content::Source<Profile>(profile_));
registrar_.Remove(this, chrome::NOTIFICATION_HISTORY_URLS_DELETED,
content::Source<Profile>(profile_));
history_service_->RemoveObserver(this);
@@ -280,6 +278,11 @@ void HistoryMenuBridge::OnURLVisited(HistoryService* history_service,
OnHistoryChanged();
}
+void HistoryMenuBridge::OnURLsModified(HistoryService* history_service,
+ const history::URLRows& changed_urls) {
+ OnHistoryChanged();
+}
+
HistoryMenuBridge::HistoryItem* HistoryMenuBridge::HistoryItemForMenuItem(
NSMenuItem* item) {
std::map<NSMenuItem*, HistoryItem*>::iterator it = menu_item_map_.find(item);
@@ -367,8 +370,6 @@ NSMenuItem* HistoryMenuBridge::AddItemToMenu(HistoryItem* item,
void HistoryMenuBridge::Init() {
DCHECK(history_service_);
- registrar_.Add(this, chrome::NOTIFICATION_HISTORY_URLS_MODIFIED,
- content::Source<Profile>(profile_));
registrar_.Add(this, chrome::NOTIFICATION_HISTORY_URLS_DELETED,
content::Source<Profile>(profile_));
history_service_->AddObserver(this);
« no previous file with comments | « chrome/browser/ui/cocoa/history_menu_bridge.h ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698