Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h.

Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h.

This removes a dependency on extension_constants.h from permissions_data.

BUG=298586
TBR=derat@chromium.org,sky@chromium.org,

[miket_OOO, 2013-11-07 21:39:41]

lgtm

https://chromiumcodereview.appspot.com/65163003/diff/1/chrome/common/extensio...
File chrome/common/extensions/extension_constants.cc (left):

https://chromiumcodereview.appspot.com/65163003/diff/1/chrome/common/extensio...
chrome/common/extensions/extension_constants.cc:49: }
I kind of regret that these are now getting sprayed all over the place. Are you
sure?

https://chromiumcodereview.appspot.com/65163003/diff/1/extensions/common/exte...
File extensions/common/extension_urls.cc (right):

https://chromiumcodereview.appspot.com/65163003/diff/1/extensions/common/exte...
extensions/common/extension_urls.cc:42: return gallery_prefix;
I know this is just move-refactoring, but (a) is the slash remover really
needed, (b) isn't there a library function to remove trailing slashes, and (c)
can you at least move the remover into the block with the command line, because
we know that kGalleryBrowsePrefix doesn't have a trailing slash?

[Yoyo Zhou, 2013-11-08 02:03:08]

https://chromiumcodereview.appspot.com/65163003/diff/1/chrome/common/extensio...
File chrome/common/extensions/extension_constants.cc (left):

https://chromiumcodereview.appspot.com/65163003/diff/1/chrome/common/extensio...
chrome/common/extensions/extension_constants.cc:49: }
On 2013/11/07 21:39:41, miket wrote:
> I kind of regret that these are now getting sprayed all over the place. Are
you
> sure?

These belong to, for example, the app list and/or the webstore, and they're each
only used in that particular place. If there was a place to just have these
strings for the app list, that'd be great, but the rest of Chrome has no need
for them.

I'm not completely sure that this is better (what happens if these strings need
to change, for example? but that seems unlikely to ever happen), but I think it
is.

https://chromiumcodereview.appspot.com/65163003/diff/1/extensions/common/exte...
File extensions/common/extension_urls.cc (right):

https://chromiumcodereview.appspot.com/65163003/diff/1/extensions/common/exte...
extensions/common/extension_urls.cc:42: return gallery_prefix;
On 2013/11/07 21:39:41, miket wrote:
> I know this is just move-refactoring, but (a) is the slash remover really
> needed, (b) isn't there a library function to remove trailing slashes, and (c)
> can you at least move the remover into the block with the command line,
because
> we know that kGalleryBrowsePrefix doesn't have a trailing slash?

For (a) and (b), I don't know. I spent some time searching for (b) and couldn't
find a satisfactory one. But we can do (c).

[commit-bot: I haz the power, 2013-11-08 02:24:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/65163003/60001

[commit-bot: I haz the power, 2013-11-08 02:46:10]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Yoyo Zhou, 2013-11-08 06:28:39]

TBR:
derat (chromeos)
sky (chrome)

[commit-bot: I haz the power, 2013-11-08 06:29:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/65163003/60001

[commit-bot: I haz the power, 2013-11-08 07:12:54]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Daniel Erat, 2013-11-08 13:28:46]

I had thought about this briefly before. Does it make sense for things that
aren't Chrome to access the Web Store? I assumed that it was a Chrome-only
service.

[Yoyo Zhou, 2013-11-08 23:04:28]

On 2013/11/08 13:28:46, Daniel Erat wrote:
> I had thought about this briefly before. Does it make sense for things that
> aren't Chrome to access the Web Store? I assumed that it was a Chrome-only
> service.

Hmm, I had thought along these lines before. The bit that we need is "is this
site forbidden to content scripts". I think I have a better solution than this
CL; thanks.