chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc - Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mt Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

diff --git a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

index f2c2055831866f9b59713766d50235254ee08496..1da303bb2e16b22a93d98d05002e36acf923d2c2 100644

--- a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

+++ b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

@@ -14,10 +14,10 @@

#include "chrome/browser/ui/gtk/gtk_chrome_link_button.h"

#include "chrome/browser/ui/gtk/gtk_util.h"

#include "chrome/common/extensions/extension.h"

-#include "chrome/common/extensions/extension_constants.h"

#include "content/public/browser/page_navigator.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_view.h"

+#include "extensions/common/extension_urls.h"

#include "grit/generated_resources.h"

#include "skia/ext/image_operations.h"

#include "ui/base/gtk/gtk_hig_constants.h"

@@ -393,7 +393,7 @@ void ExtensionInstallDialog::OnResponse(GtkWidget* dialog, int response_id) {

void ExtensionInstallDialog::OnStoreLinkClick(GtkWidget* sender) {

GURL store_url(

- extension_urls::GetWebstoreItemDetailURLPrefix() + extension_id_);

+ extensions::GetWebstoreItemDetailURLPrefix() + extension_id_);

navigator_->OpenURL(OpenURLParams(

store_url, content::Referrer(), NEW_FOREGROUND_TAB,

content::PAGE_TRANSITION_LINK, false));