chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm - Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mt Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/webstore/webstore_result.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

index a8699160e2c5b0f606f511a503d3cea6ae625d5b..90e437dec1e329391c849be72274631ba39baf91 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

@@ -21,11 +21,11 @@

#import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"

#include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"

#include "chrome/common/extensions/extension.h"

-#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/manifest_url_handler.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/web_contents.h"

+#include "extensions/common/url_constants.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util_mac.h"

@@ -153,8 +153,7 @@ class AsyncUninstaller : public ExtensionUninstallDialog::Delegate {

}

- (void)onExtensionName:(id)sender {

- GURL url(std::string(extension_urls::kGalleryBrowsePrefix) +

- std::string("/detail/") + extension_->id());

+ GURL url(extensions::GetWebstoreItemDetailURLPrefix() + extension_->id());

OpenURLParams params(url,

Referrer(),

NEW_FOREGROUND_TAB,