chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm - Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mt Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm ('k') | chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

index d6495df6d0acf1338e55de384b4ea94bcc217e2e..927d656664af413653cbc55b829fc1608c67357a 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

@@ -14,8 +14,8 @@

#include "chrome/browser/extensions/bundle_installer.h"

#import "chrome/browser/ui/chrome_style.h"

#include "chrome/common/extensions/extension.h"

-#include "chrome/common/extensions/extension_constants.h"

#include "content/public/browser/page_navigator.h"

+#include "extensions/common/url_constants.h"

#include "grit/generated_resources.h"

#include "skia/ext/skia_utils_mac.h"

#import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"

@@ -208,7 +208,7 @@ bool HasAttribute(id item, CellAttributesMask attributeMask) {

}

- (IBAction)storeLinkClicked:(id)sender {

- GURL store_url(extension_urls::GetWebstoreItemDetailURLPrefix() +

+ GURL store_url(extensions::GetWebstoreItemDetailURLPrefix() +

prompt_->extension()->id());

navigator_->OpenURL(OpenURLParams(

store_url, Referrer(), NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK,