Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

Issue 65163003: Move GetWebstoreLaunchURL and GetWebstoreItemDetailURLPrefix to extensions/common/extension_urls.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mt Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu_contro ller.h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu_contro ller.h"
6 6
7 #include "base/strings/sys_string_conversions.h" 7 #include "base/strings/sys_string_conversions.h"
8 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h" 8 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
9 #include "chrome/browser/extensions/extension_action_manager.h" 9 #include "chrome/browser/extensions/extension_action_manager.h"
10 #include "chrome/browser/extensions/extension_service.h" 10 #include "chrome/browser/extensions/extension_service.h"
11 #include "chrome/browser/extensions/extension_system.h" 11 #include "chrome/browser/extensions/extension_system.h"
12 #include "chrome/browser/extensions/extension_tab_util.h" 12 #include "chrome/browser/extensions/extension_tab_util.h"
13 #include "chrome/browser/extensions/extension_uninstall_dialog.h" 13 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/ui/browser.h" 15 #include "chrome/browser/ui/browser.h"
16 #include "chrome/browser/ui/chrome_pages.h" 16 #include "chrome/browser/ui/chrome_pages.h"
17 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h" 17 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
18 #include "chrome/browser/ui/cocoa/browser_window_controller.h" 18 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
19 #include "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h" 19 #include "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
20 #include "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h" 20 #include "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
21 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" 21 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
22 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h" 22 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
23 #include "chrome/common/extensions/extension.h" 23 #include "chrome/common/extensions/extension.h"
24 #include "chrome/common/extensions/extension_constants.h"
25 #include "chrome/common/extensions/manifest_url_handler.h" 24 #include "chrome/common/extensions/manifest_url_handler.h"
26 #include "chrome/common/pref_names.h" 25 #include "chrome/common/pref_names.h"
27 #include "chrome/common/url_constants.h" 26 #include "chrome/common/url_constants.h"
28 #include "content/public/browser/web_contents.h" 27 #include "content/public/browser/web_contents.h"
28 #include "extensions/common/url_constants.h"
29 #include "grit/chromium_strings.h" 29 #include "grit/chromium_strings.h"
30 #include "grit/generated_resources.h" 30 #include "grit/generated_resources.h"
31 #include "ui/base/l10n/l10n_util_mac.h" 31 #include "ui/base/l10n/l10n_util_mac.h"
32 32
33 using content::OpenURLParams; 33 using content::OpenURLParams;
34 using content::Referrer; 34 using content::Referrer;
35 using content::WebContents; 35 using content::WebContents;
36 using extensions::Extension; 36 using extensions::Extension;
37 37
38 // A class that shows a confirmation dialog to uninstall the given extension. 38 // A class that shows a confirmation dialog to uninstall the given extension.
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 if (devMode) { 146 if (devMode) {
147 item = [menu addItemWithTitle:l10n_util::GetNSStringWithFixup( 147 item = [menu addItemWithTitle:l10n_util::GetNSStringWithFixup(
148 IDS_EXTENSION_ACTION_INSPECT_POPUP) 148 IDS_EXTENSION_ACTION_INSPECT_POPUP)
149 action:@selector(onInspect:) 149 action:@selector(onInspect:)
150 keyEquivalent:@""]; 150 keyEquivalent:@""];
151 [item setTarget:self]; 151 [item setTarget:self];
152 } 152 }
153 } 153 }
154 154
155 - (void)onExtensionName:(id)sender { 155 - (void)onExtensionName:(id)sender {
156 GURL url(std::string(extension_urls::kGalleryBrowsePrefix) + 156 GURL url(extensions::GetWebstoreItemDetailURLPrefix() + extension_->id());
157 std::string("/detail/") + extension_->id());
158 OpenURLParams params(url, 157 OpenURLParams params(url,
159 Referrer(), 158 Referrer(),
160 NEW_FOREGROUND_TAB, 159 NEW_FOREGROUND_TAB,
161 content::PAGE_TRANSITION_LINK, 160 content::PAGE_TRANSITION_LINK,
162 false); 161 false);
163 browser_->OpenURL(params); 162 browser_->OpenURL(params);
164 } 163 }
165 164
166 - (void)onOptions:(id)sender { 165 - (void)onOptions:(id)sender {
167 DCHECK(!extensions::ManifestURL::GetOptionsPage(extension_).is_empty()); 166 DCHECK(!extensions::ManifestURL::GetOptionsPage(extension_).is_empty());
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 return; 215 return;
217 216
218 [ExtensionPopupController showURL:url 217 [ExtensionPopupController showURL:url
219 inBrowser:browser_ 218 inBrowser:browser_
220 anchoredAt:popupPoint 219 anchoredAt:popupPoint
221 arrowLocation:info_bubble::kTopRight 220 arrowLocation:info_bubble::kTopRight
222 devMode:YES]; 221 devMode:YES];
223 } 222 }
224 223
225 @end 224 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698