|
This patch is trying to accomplish two major objectives:
* Make Change.deps (now Change.commits) ordered. In the case of multiple DEPS
rolls, e.g. clank@1 chromium@2 v8@3, we need them in order to know that v8@3
is the one to display in the UI.
* Simplify and correct the Change.Midpoint() logic. It was incorrect in the case
of change_a == chromium@1, change_b == chromium@1 v8@4. It was giving no
midpoint, when we expected chromium@1 v8@2. Hopefully the logic is easier to
follow now.
In addition, I've tacked on some other things that were on my wishlist:
* Rename Dep to Commit.
* Split change.py into separate modules for Change, Commit, and Patch.
* Make the Change.Midpoint() unit tests much easier to grok and write.
Review-Url: https://chromiumcodereview.appspot.com/3013013002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5638c631c865e13614c71c6b68bc5a1f69806742
Total comments: 21
Total comments: 4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+874 lines, -812 lines) |
Patch |
|
M |
dashboard/dashboard/pinpoint/elements/change-info.html
|
View
|
1
2
3
4
|
4 chunks |
+19 lines, -32 lines |
0 comments
|
Download
|
|
M |
dashboard/dashboard/pinpoint/handlers/isolate_test.py
|
View
|
|
7 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
dashboard/dashboard/pinpoint/handlers/new.py
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
D |
dashboard/dashboard/pinpoint/models/change.py
|
View
|
|
1 chunk |
+0 lines, -334 lines |
0 comments
|
Download
|
|
A |
dashboard/dashboard/pinpoint/models/change/__init__.py
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
|
A |
dashboard/dashboard/pinpoint/models/change/change.py
|
View
|
1
2
3
|
1 chunk |
+212 lines, -0 lines |
4 comments
|
Download
|
|
A |
dashboard/dashboard/pinpoint/models/change/change_test.py
|
View
|
1
2
|
1 chunk |
+209 lines, -0 lines |
0 comments
|
Download
|
|
A |
dashboard/dashboard/pinpoint/models/change/commit.py
|
View
|
1
2
|
1 chunk |
+166 lines, -0 lines |
0 comments
|
Download
|
|
A |
dashboard/dashboard/pinpoint/models/change/commit_test.py
|
View
|
1
2
|
1 chunk |
+154 lines, -0 lines |
0 comments
|
Download
|
|
A |
dashboard/dashboard/pinpoint/models/change/patch.py
|
View
|
|
1 chunk |
+26 lines, -0 lines |
0 comments
|
Download
|
|
A |
dashboard/dashboard/pinpoint/models/change/patch_test.py
|
View
|
|
1 chunk |
+39 lines, -0 lines |
0 comments
|
Download
|
|
D |
dashboard/dashboard/pinpoint/models/change_test.py
|
View
|
|
1 chunk |
+0 lines, -405 lines |
0 comments
|
Download
|
|
M |
dashboard/dashboard/pinpoint/models/isolate_test.py
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
dashboard/dashboard/pinpoint/models/job.py
|
View
|
1
2
|
2 chunks |
+14 lines, -15 lines |
0 comments
|
Download
|
|
M |
dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py
|
View
|
|
8 chunks |
+13 lines, -12 lines |
0 comments
|
Download
|
Total messages: 15 (6 generated)
|