[pinpoint] Change refactor.

dashboard/dashboard/pinpoint/models/job.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import logging
 import os
 import traceback
 
 from google.appengine.api import taskqueue
@@ skipping 151 matching lines @@
   def _PostBugComment(self, status):
     if not self.bug_id:
       return
 
     title = '%s Pinpoint job %s.' % (_ROUND_PUSHPIN, status)
     header = '\n'.join((title, self.url))
 
     # Include list of Changes.
     change_details = []
     for _, change in self.state.Differences():
-      # TODO: Only show the most specific Dep.
-      # TODO: Store the commit info in the Dep.
-      for dep in change.all_deps:
-        commit_info = gitiles_service.CommitInfo(dep.repository_url, dep.git_hash)
-        subject = commit_info['message'].split('\n', 1)[0]
-        author = commit_info['author']['email']
-        time = commit_info['committer']['time']
+      # TODO: Store the commit info in the Commit.
+      commit = change.last_commit
+      commit_info = gitiles_service.CommitInfo(commit.repository_url,
+                                               commit.git_hash)
+      subject = commit_info['message'].split('\n', 1)[0]
+      author = commit_info['author']['email']
+      time = commit_info['committer']['time']
 
-        byline = 'By %s %s %s' % (author, _MIDDLE_DOT, time)
-        git_link = dep.repository + '@' + dep.git_hash
-        change_details.append('\n'.join((subject, byline, git_link)))
+      byline = 'By %s %s %s' % (author, _MIDDLE_DOT, time)
+      git_link = commit.repository + '@' + commit.git_hash
+      change_details.append('\n'.join((subject, byline, git_link)))
 
     comment = '\n\n'.join([header] + change_details)
 
     issue_tracker = issue_tracker_service.IssueTrackerService(
         utils.ServiceAccountHttp())
     issue_tracker.AddBugComment(self.bug_id, comment, send_email=False)
 
 
 class _JobState(object):
   """The internal state of a Job.
@@ skipping 59 matching lines @@
     for index in xrange(1, len(self._changes)):
       change_a = self._changes[index - 1]
       change_b = self._changes[index]
 
       comparison_result = self._Compare(change_a, change_b)
       if comparison_result == _DIFFERENT:
         # Different: Bisect and add an additional Change to the job.
         try:
           midpoint = change_module.Change.Midpoint(change_a, change_b)
         except change_module.NonLinearError:
-          midpoint = None
-        if midpoint:
-          logging.info('Adding Change %s.', midpoint)
-          self.AddChange(midpoint, index)
+          continue
+        logging.info('Adding Change %s.', midpoint)
+        self.AddChange(midpoint, index)
       elif comparison_result == _SAME:
         # The same: Do nothing.
         continue
       elif comparison_result == _UNKNOWN:
         # Unknown: Add an Attempt to the Change with the fewest Attempts.
         change = min(change_a, change_b, key=lambda c: len(self._attempts[c]))
         self.AddAttempt(change)
 
   def ScheduleWork(self):
     work_left = False
@@ skipping 96 matching lines @@
 
   try:
     p_value = mann_whitney_u.MannWhitneyU(values_a, values_b)
   except ValueError:
     return _UNKNOWN
 
   if p_value < _SIGNIFICANCE_LEVEL:
     return _DIFFERENT
   else:
     return _UNKNOWN