[pinpoint] Change refactor.

dashboard/dashboard/pinpoint/models/change/change_test.py

Index: dashboard/dashboard/pinpoint/models/change/change_test.py
diff --git a/dashboard/dashboard/pinpoint/models/change/change_test.py b/dashboard/dashboard/pinpoint/models/change/change_test.py
new file mode 100644
index 0000000000000000000000000000000000000000..d47ff4b4330fc5e8f454c266c88cf8f2064d8346
--- /dev/null
+++ b/dashboard/dashboard/pinpoint/models/change/change_test.py
@@ -0,0 +1,209 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import mock
+
+from dashboard.common import namespaced_stored_object
+from dashboard.common import testing_common
+from dashboard.pinpoint.models.change import change
+from dashboard.pinpoint.models.change import commit
+from dashboard.pinpoint.models.change import patch
+
+
+_CATAPULT_URL = ('https://chromium.googlesource.com/'
+                 'external/github.com/catapult-project/catapult')
+_CHROMIUM_URL = 'https://chromium.googlesource.com/chromium/src'
+
+
+class _ChangeTest(testing_common.TestCase):
+
+  def setUp(self):
+    super(_ChangeTest, self).setUp()
+
+    self.SetCurrentUser('internal@chromium.org', is_admin=True)
+
+    namespaced_stored_object.Set('repositories', {
+        'catapult': {'repository_url': _CATAPULT_URL},
+        'chromium': {'repository_url': _CHROMIUM_URL},
+    })
+
+
+class ChangeTest(_ChangeTest):
+
+  def testChange(self):
+    base_commit = commit.Commit('chromium', 'aaa7336c821888839f759c6c0a36b56c')
+    dep = commit.Commit('catapult', 'e0a2efbb3d1a81aac3c90041eefec24f066d26ba')
+    p = patch.Patch('https://codereview.chromium.org', 2565263002, 20001)
+
+    # Also test the deps conversion to frozenset.
+    c = change.Change([base_commit, dep], p)
+
+    self.assertEqual(c, change.Change((base_commit, dep), p))
+    string = ('chromium@aaa7336 catapult@e0a2efb + '
+              'https://codereview.chromium.org/2565263002/20001')
+    id_string = ('chromium@aaa7336c821888839f759c6c0a36b56c '
+                 'catapult@e0a2efbb3d1a81aac3c90041eefec24f066d26ba + '
+                 'https://codereview.chromium.org/2565263002/20001')
+    self.assertEqual(str(c), string)
+    self.assertEqual(c.id_string, id_string)
+    self.assertEqual(c.base_commit, base_commit)
+    self.assertEqual(c.last_commit, dep)
+    self.assertEqual(c.deps, (dep,))
+    self.assertEqual(c.commits, (base_commit, dep))
+    self.assertEqual(c.patch, p)
+
+  def testAsDict(self):
+    commits = (commit.Commit('chromium', 'aaa7336c82'),
+               commit.Commit('catapult', 'e0a2efbb3d'))
+    p = patch.Patch('https://codereview.chromium.org', 2565263002, 20001)
+    c = change.Change(commits, p)
+
+    expected = {
+        'commits': [
+            {
+                'repository': 'chromium',
+                'git_hash': 'aaa7336c82',
+                'url': _CHROMIUM_URL + '/+/aaa7336c82',
+            },
+            {
+                'repository': 'catapult',
+                'git_hash': 'e0a2efbb3d',
+                'url': _CATAPULT_URL + '/+/e0a2efbb3d',
+            },
+        ],
+        'patch': {
+            'server': 'https://codereview.chromium.org',
+            'issue': 2565263002,
+            'patchset': 20001,
+        },
+    }
+    self.assertEqual(c.AsDict(), expected)
+
+  @mock.patch('dashboard.services.gitiles_service.CommitInfo')
+  def testFromDictWithJustOneCommit(self, _):
+    c = change.Change.FromDict({
+        'commits': [{'repository': 'chromium', 'git_hash': 'aaa7336'}],
+    })
+
+    expected = change.Change((commit.Commit('chromium', 'aaa7336'),))
+    self.assertEqual(c, expected)
+
+  @mock.patch('dashboard.services.gitiles_service.CommitInfo')
+  def testFromDictWithAllFields(self, _):
+    c = change.Change.FromDict({
+        'commits': (
+            {'repository': 'chromium', 'git_hash': 'aaa7336'},
+            {'repository': 'catapult', 'git_hash': 'e0a2efb'},
+        ),
+        'patch': {
+            'server': 'https://codereview.chromium.org',
+            'issue': 2565263002,
+            'patchset': 20001,
+        },
+    })
+
+    commits = (commit.Commit('chromium', 'aaa7336'),
+               commit.Commit('catapult', 'e0a2efb'))
+    p = patch.Patch('https://codereview.chromium.org', 2565263002, 20001)
+    expected = change.Change(commits, p)
+    self.assertEqual(c, expected)
+
+
+class MidpointTest(_ChangeTest):
+
+  def setUp(self):
+    super(MidpointTest, self).setUp()
+
+    patcher = mock.patch('dashboard.services.gitiles_service.CommitRange')
+    self.addCleanup(patcher.stop)
+    commit_range = patcher.start()
+    def _CommitRange(repository_url, first_git_hash, last_git_hash):
+      del repository_url
+      first_git_hash = int(first_git_hash)
+      last_git_hash = int(last_git_hash)
+      return [{'commit': x} for x in xrange(last_git_hash, first_git_hash, -1)]
+    commit_range.side_effect = _CommitRange
+
+    patcher = mock.patch('dashboard.services.gitiles_service.FileContents')
+    self.addCleanup(patcher.stop)
+    file_contents = patcher.start()
+    def _FileContents(repository_url, git_hash, path):
+      del path
+      if repository_url != _CHROMIUM_URL:
+        return 'deps = {}'
+      if git_hash <= 4:  # DEPS roll at chromium@5
+        return 'deps = {"chromium/catapult": "%s@0"}' % (_CATAPULT_URL + '.git')
+      else:
+        return 'deps = {"chromium/catapult": "%s@9"}' % _CATAPULT_URL
+    file_contents.side_effect = _FileContents
+
+  def testDifferingPatch(self):
+    change_a = change.Change((commit.Commit('chromium', '0e57e2b'),))
+    change_b = change.Change(
+        (commit.Commit('chromium', 'babe852'),),
+        patch=patch.Patch('https://codereview.chromium.org', 2565263002, 20001))
+    with self.assertRaises(commit.NonLinearError):
+      change.Change.Midpoint(change_a, change_b)
+
+  def testDifferingRepository(self):
+    change_a = change.Change((commit.Commit('chromium', '0e57e2b'),))
+    change_b = change.Change((commit.Commit('not_chromium', 'babe852'),))
+    with self.assertRaises(commit.NonLinearError):
+      change.Change.Midpoint(change_a, change_b)
+
+  def testDifferingCommitCount(self):
+    change_a = change.Change((commit.Commit('chromium', 0),))
+    change_b = change.Change((commit.Commit('chromium', 9),
+                              commit.Commit('not_chromium', 'babe852')))
+    with self.assertRaises(commit.NonLinearError):
+      change.Change.Midpoint(change_a, change_b)
+
+  def testSameChange(self):
+    change_a = change.Change((commit.Commit('chromium', 0),))
+    change_b = change.Change((commit.Commit('chromium', 0),))
+    with self.assertRaises(commit.NonLinearError):
+      change.Change.Midpoint(change_a, change_b)
+
+  def testAdjacentWithNoDepsRoll(self):
+    change_a = change.Change((commit.Commit('chromium', 0),))
+    change_b = change.Change((commit.Commit('chromium', 1),))
+    with self.assertRaises(commit.NonLinearError):
+      change.Change.Midpoint(change_a, change_b)
+
+  def testAdjacentWithDepsRoll(self):
+    change_a = change.Change((commit.Commit('chromium', 4),))
+    change_b = change.Change((commit.Commit('chromium', 5),))
+    expected = change.Change((commit.Commit('chromium', 4),
+                              commit.Commit('catapult', 4)))
+    self.assertEqual(change.Change.Midpoint(change_a, change_b), expected)
+
+  def testNotAdjacent(self):
+    change_a = change.Change((commit.Commit('chromium', 0),))
+    change_b = change.Change((commit.Commit('chromium', 9),))
+    self.assertEqual(change.Change.Midpoint(change_a, change_b),
+                     change.Change((commit.Commit('chromium', 4),)))
+
+  def testDepsRollLeft(self):
+    change_a = change.Change((commit.Commit('chromium', 4),))
+    change_b = change.Change((commit.Commit('chromium', 4),
+                              commit.Commit('catapult', 4)))
+    expected = change.Change((commit.Commit('chromium', 4),
+                              commit.Commit('catapult', 2)))
+    self.assertEqual(change.Change.Midpoint(change_a, change_b), expected)
+
+  def testDepsRollRight(self):
+    change_a = change.Change((commit.Commit('chromium', 4),
+                              commit.Commit('catapult', 4)))
+    change_b = change.Change((commit.Commit('chromium', 5),))
+    expected = change.Change((commit.Commit('chromium', 4),
+                              commit.Commit('catapult', 6)))
+    self.assertEqual(change.Change.Midpoint(change_a, change_b), expected)
+
+  def testAdjacentWithDepsRollAndDepAlreadyOverridden(self):
+    change_a = change.Change((commit.Commit('chromium', 4),))
+    change_b = change.Change((commit.Commit('chromium', 5),
+                              commit.Commit('catapult', 4)))
+    expected = change.Change((commit.Commit('chromium', 4),
+                              commit.Commit('catapult', 2)))
+    self.assertEqual(change.Change.Midpoint(change_a, change_b), expected)