Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2914)

Unified Diff: dashboard/dashboard/pinpoint/models/job.py

Issue 3013013002: [pinpoint] Change refactor. (Closed)
Patch Set: UI Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/models/job.py
diff --git a/dashboard/dashboard/pinpoint/models/job.py b/dashboard/dashboard/pinpoint/models/job.py
index 74cc46a3bd27f297e545410c1de720b5112c3ec6..8efe7cc084b3fe57261ff8f502c478f79cbfd507 100644
--- a/dashboard/dashboard/pinpoint/models/job.py
+++ b/dashboard/dashboard/pinpoint/models/job.py
@@ -169,17 +169,17 @@ class Job(ndb.Model):
# Include list of Changes.
change_details = []
for _, change in self.state.Differences():
- # TODO: Only show the most specific Dep.
- # TODO: Store the commit info in the Dep.
- for dep in change.all_deps:
- commit_info = gitiles_service.CommitInfo(dep.repository_url, dep.git_hash)
- subject = commit_info['message'].split('\n', 1)[0]
- author = commit_info['author']['email']
- time = commit_info['committer']['time']
-
- byline = 'By %s %s %s' % (author, _MIDDLE_DOT, time)
- git_link = dep.repository + '@' + dep.git_hash
- change_details.append('\n'.join((subject, byline, git_link)))
+ # TODO: Store the commit info in the Commit.
+ commit = change.last_commit
+ commit_info = gitiles_service.CommitInfo(commit.repository_url,
+ commit.git_hash)
+ subject = commit_info['message'].split('\n', 1)[0]
+ author = commit_info['author']['email']
+ time = commit_info['committer']['time']
+
+ byline = 'By %s %s %s' % (author, _MIDDLE_DOT, time)
+ git_link = commit.repository + '@' + commit.git_hash
+ change_details.append('\n'.join((subject, byline, git_link)))
comment = '\n\n'.join([header] + change_details)
@@ -259,10 +259,9 @@ class _JobState(object):
try:
midpoint = change_module.Change.Midpoint(change_a, change_b)
except change_module.NonLinearError:
- midpoint = None
- if midpoint:
- logging.info('Adding Change %s.', midpoint)
- self.AddChange(midpoint, index)
+ continue
+ logging.info('Adding Change %s.', midpoint)
+ self.AddChange(midpoint, index)
elif comparison_result == _SAME:
# The same: Do nothing.
continue

Powered by Google App Engine
This is Rietveld 408576698