Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2957513002: Removed calls to RefPtr::Release in return statements with auto move. (Closed)

Created:
3 years, 6 months ago by Bugs Nash
Modified:
3 years, 6 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, eric.carlson_apple.com, Eric Willigers, feature-media-reviews_chromium.org, fmalita+watch_chromium.org, fs, gyuyoung2, haraken, hongchan, jbroman+watch_chromium.org, jchaffraix+rendering, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rjwright, rwlbuis, Raymond Toy, Stephen Chennney, shans, sof, Srirama, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed calls to RefPtr::Release in return statements with auto move. Removed calls to RefPtr::Release in return statements that automatically move the object returned (i.e. where the RefPtr returned is local to the method). These methods still return a PassRefPtr and so the RefPtr will be implicitly converted to a PassRefPtr. Future patches will change the return types to RefPtr. BUG=494719 Review-Url: https://codereview.chromium.org/2957513002 Cr-Commit-Position: refs/heads/master@{#482178} Committed: https://chromium.googlesource.com/chromium/src/+/2083513f84c5d1c914275031d0064875e27b28f8

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -67 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Keyframe.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/FormData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlMultiLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/BasicShapes.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FormDataBytesConsumer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/EncodedFormData.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
Bugs Nash
3 years, 6 months ago (2017-06-23 02:08:44 UTC) #4
haraken
LGTM assuming that this won't have any performance impact.
3 years, 6 months ago (2017-06-23 02:25:37 UTC) #7
Yuta Kitamura
LGTM The changes in this file do not change the runtime behavior, so the performance ...
3 years, 6 months ago (2017-06-23 06:29:08 UTC) #8
Bugs Nash
rebased
3 years, 6 months ago (2017-06-25 22:27:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957513002/20001
3 years, 6 months ago (2017-06-25 22:28:14 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-26 00:19:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2083513f84c5d1c914275031d006...

Powered by Google App Engine
This is Rietveld 408576698