third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp - Issue 2957513002: Removed calls to RefPtr::Release in return statements with auto move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2957513002: Removed calls to RefPtr::Release in return statements with auto move. (Closed)

Patch Set: rebased Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

index aec4122f87f3e40cab0369bb0c1ed871fb1ac944..0d8fe07592db85d3f42eb3bf6b7a6b57b69ba8b0 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

@@ -583,7 +583,7 @@ PassRefPtr<ComputedStyle> StyleResolver::StyleForDocument(Document& document) {

document.SetupFontBuilder(*document_style);

- return document_style.Release();

+ return document_style;

}

void StyleResolver::AdjustComputedStyle(StyleResolverState& state,

@@ -676,7 +676,7 @@ PassRefPtr<ComputedStyle> StyleResolver::StyleForElement(

(default_parent || element_context.ParentStyle())) {

if (RefPtr<ComputedStyle> shared_style =

GetDocument().GetStyleEngine().FindSharedStyle(element_context))

- return shared_style.Release();

+ return shared_style;

}

StyleResolverState state(GetDocument(), element_context, default_parent,

@@ -1057,7 +1057,7 @@ PassRefPtr<ComputedStyle> StyleResolver::InitialStyleForElement() {

font_builder.SetInitial(style->EffectiveZoom());

font_builder.CreateFont(GetDocument().GetStyleEngine().FontSelector(),

*style);

- return style.Release();

+ return style;

}

PassRefPtr<ComputedStyle> StyleResolver::StyleForText(Text* text_node) {