third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp - Issue 2957513002: Removed calls to RefPtr::Release in return statements with auto move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

Issue 2957513002: Removed calls to RefPtr::Release in return statements with auto move. (Closed)

Patch Set: rebased Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

diff --git a/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp b/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

index 25e0608ffa9dff9b8dcf51bdef05ebe0f9f276e2..5f1fa38928c8cfcd3b8470cb5c648b4116a29f47 100644

--- a/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

+++ b/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

@@ -157,7 +157,7 @@ PassRefPtr<DOMWrapperWorld> DOMWrapperWorld::EnsureIsolatedWorld(

RefPtr<DOMWrapperWorld> world = it->value;

DCHECK(world->IsIsolatedWorld());

DCHECK_EQ(world_id, world->GetWorldId());

- return world.Release();

+ return world;

}

return AdoptRef(new DOMWrapperWorld(isolate, WorldType::kIsolated, world_id));