third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp - Issue 2957513002: Removed calls to RefPtr::Release in return statements with auto move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2957513002: Removed calls to RefPtr::Release in return statements with auto move. (Closed)

Patch Set: rebased Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

index 9c63a148c456bb723ac1772932202379a4fc5451..8af5ec466cca55436302fb90bd7ac090f3fb6dd7 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

@@ -106,7 +106,7 @@ PassRefPtr<StyleReflection> StyleBuilderConverter::ConvertBoxReflect(

reflection->SetMask(mask);

}

- return reflection.Release();

+ return reflection;

}

Color StyleBuilderConverter::ConvertColor(StyleResolverState& state,

@@ -1066,7 +1066,7 @@ PassRefPtr<QuotesData> StyleBuilderConverter::ConvertQuotes(

String end_quote = ToCSSStringValue(list.Item(i + 1)).Value();

quotes->AddPair(std::make_pair(start_quote, end_quote));

}

- return quotes.Release();

+ return quotes;

}

DCHECK_EQ(ToCSSIdentifierValue(value).GetValueID(), CSSValueNone);

return QuotesData::Create();

@@ -1199,7 +1199,7 @@ PassRefPtr<SVGDashArray> StyleBuilderConverter::ConvertStrokeDasharray(

array->push_back(ConvertLength(state, ToCSSPrimitiveValue(dashes.Item(i))));

}

- return array.Release();

+ return array;

}

StyleColor StyleBuilderConverter::ConvertStyleColor(StyleResolverState& state,