DescriptionMake FaviconService::GetRawFaviconForPageURL() select the best candidate among all the icon types
This CL changes the behavior of FaviconService::GetRawFaviconForPageURL() when
multiple icon types are passed in.
Scenario:
A page_url is mapped to:
icon_url1 of type FAVICON
icon_url2 of type TOUCH_ICON
Previously
FaviconService::GetRawFaviconForPageURL(*, FAVICON | TOUCH_ICON, *, *) returned
the TOUCH_ICON regardless of which icon url was a better match because
TOUCH_ICONs had precence over FAVICONs.
This CL changes
FaviconService::GetRawFaviconForPageURL(*, FAVICON | TOUCH_ICON, *, *)
to return the icon url which is a better match.
This CL changes the behavior FaviconHelper#getLocalFaviconImageForURL()
BUG=712466
Review-Url: https://codereview.chromium.org/2823093002
Cr-Commit-Position: refs/heads/master@{#471674}
Committed: https://chromium.googlesource.com/chromium/src/+/1fb2030a6e961c668f3636d6fb65ca4effee0341
Patch Set 1 : Merge branch 'master' into icon_type #
Total comments: 4
Patch Set 2 : Merge branch 'icon_type0' into icon_type #
Total comments: 6
Patch Set 3 : Merge branch 'icon_type0' into icon_type #Patch Set 4 : Merge branch 'icon_type0' into icon_type #
Total comments: 1
Patch Set 5 : Merge branch 'master' into icon_type #
Messages
Total messages: 27 (14 generated)
|