Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: components/history/core/browser/thumbnail_database.cc

Issue 2823093002: Make FaviconService::GetRawFaviconForPageURL() select the best candidate among all the icon types (Closed)
Patch Set: Merge branch 'master' into icon_type Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/thumbnail_database.cc
diff --git a/components/history/core/browser/thumbnail_database.cc b/components/history/core/browser/thumbnail_database.cc
index b8838abc90cf67059151f618c39facd8402d3d6d..60445eb48f0dc66b6f7bc4dd12dedc3898a0327a 100644
--- a/components/history/core/browser/thumbnail_database.cc
+++ b/components/history/core/browser/thumbnail_database.cc
@@ -673,11 +673,6 @@ bool ThumbnailDatabase::GetIconMappingsForPageURL(
if (!filtered_mapping_data)
return result;
- // Restrict icon type of subsequent matches to |m->icon_type|.
- // |m->icon_type| is the largest IconType in |mapping_data| because
- // |mapping_data| is sorted in descending order of IconType.
- required_icon_types = m->icon_type;
-
filtered_mapping_data->push_back(*m);
}
}
« no previous file with comments | « components/history/core/browser/thumbnail_database.h ('k') | components/history/core/browser/thumbnail_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698