components/history/core/browser/history_service.h - Issue 2823093002: Make FaviconService::GetRawFaviconForPageURL() select the best candidate among all the icon types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_service.h

Issue 2823093002: Make FaviconService::GetRawFaviconForPageURL() select the best candidate among all the icon types (Closed)

Patch Set: Merge branch 'master' into icon_type Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_service.h

diff --git a/components/history/core/browser/history_service.h b/components/history/core/browser/history_service.h

index f240fedcb99b6597e107c453e1f5563df56087f7..b1aedcdf65599ab0482f601fae9c1f5f029d1d52 100644

--- a/components/history/core/browser/history_service.h

+++ b/components/history/core/browser/history_service.h

@@ -663,9 +663,7 @@ class HistoryService : public syncer::SyncableService, public KeyedService {

// |icon_types| is returned. The returned FaviconBitmapResults will have at

// most one result for each entry in |desired_sizes|. If a favicon bitmap is

// determined to be the best candidate for multiple |desired_sizes| there

- // will be fewer results. If |icon_types| has several types, results for only

- // a single type will be returned in the priority of TOUCH_PRECOMPOSED_ICON,

- // TOUCH_ICON, and FAVICON.

+ // will be fewer results.

base::CancelableTaskTracker::TaskId GetFaviconsForURL(

const GURL& page_url,

int icon_types,