Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: components/favicon/core/favicon_service.h

Issue 2823093002: Make FaviconService::GetRawFaviconForPageURL() select the best candidate among all the icon types (Closed)
Patch Set: Merge branch 'master' into icon_type Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/history/core/browser/history_backend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_service.h
diff --git a/components/favicon/core/favicon_service.h b/components/favicon/core/favicon_service.h
index 09d02189f4c42f24c00194f2f944305f43a48671..d36180093497dc83e2031acae57945ebdfbb56be 100644
--- a/components/favicon/core/favicon_service.h
+++ b/components/favicon/core/favicon_service.h
@@ -88,13 +88,9 @@ class FaviconService : public KeyedService {
// Requests the favicon for the page at |page_url| with one of |icon_types|
// and with |desired_size_in_pixel|. |icon_types| can be any combination of
- // IconTypes. If favicon bitmaps for several IconTypes are available, the
- // favicon bitmap is chosen in the priority of TOUCH_PRECOMPOSED_ICON,
- // TOUCH_ICON and FAVICON. If there is no favicon bitmap of size
- // |desired_size_in_pixel|, the favicon bitmap which best matches
- // |desired_size_in_pixel| is resized. If |desired_size_in_pixel| is 0,
- // the largest favicon bitmap is returned. Results with a higher priority
- // IconType are preferred over an exact match of the favicon bitmap size.
+ // IconTypes. If there is no favicon bitmap of size |desired_size_in_pixel|,
+ // the favicon bitmap which best matches |desired_size_in_pixel| is resized.
+ // If |desired_size_in_pixel| is 0, the largest favicon bitmap is returned.
virtual base::CancelableTaskTracker::TaskId GetRawFaviconForPageURL(
const GURL& page_url,
int icon_types,
« no previous file with comments | « no previous file | components/history/core/browser/history_backend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698