Don't delete the PermissionPromptAndroid when switching tabs

Don't delete the PermissionPromptAndroid when switching tabs

The PermissionRequestManager creates and deletes its PermissionPrompt
when switching to and from a given tab. On desktop this is the mechanism
by which we hide/show permission prompts when switching tabs. On Android
however, we use infobars which already have their visibility managed, so
it's odd for the permissions code to be deleting and re-creating the
infobars instead of letting them work normally.

This patch makes us leave the PermissionPromptAndroid alone instead of
deleting and re-creating it on switching tabs. While this makes our
model on Android differ from desktop, this lets the permission infobars
be managed normally, and the PermissionPromptAndroid won't need to keep
a reference to the infobar.

This is mostly a revert of https://codereview.chromium.org/2522373002.

BUG=606138
Review-Url: https://codereview.chromium.org/2781803002
Cr-Commit-Position: refs/heads/master@{#461042}
Committed: https://chromium.googlesource.com/chromium/src/+/f9de5648278de3e68a7c7ef87215a8d3128eb763

[Timothy Loh, 2017-03-28 04:03:38]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 04:03:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 06:31:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 06:31:24]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2017-03-29 04:09:09]

Description was changed from

==========
Don't delete the PermissionPromptAndroid when switching tabs

The PermissionRequestManager creates and deletes its PermissionPrompt
when switching to and from a given tab. On desktop this is the mechanism
by which we hide/show permission prompts when switching tabs. On Android
however, we use infobars which already have their visibility managed, so
it's odd for the permissions code to be deleting and re-creating the
infobars instead of letting them work normally.

This patch makes us leave the PermissionPromptAndroid alone instead of
deleting and re-creating it on switching tabs. While this makes our
model on Android differ from desktop, this lets the permission infobars
be managed normally, and the PermissionPromptAndroid won't need to keep
a reference to the infobar.

This patch is mostly a revert of crrev.com/2522373002.

BUG=606138
==========

to

==========
Don't delete the PermissionPromptAndroid when switching tabs

The PermissionRequestManager creates and deletes its PermissionPrompt
when switching to and from a given tab. On desktop this is the mechanism
by which we hide/show permission prompts when switching tabs. On Android
however, we use infobars which already have their visibility managed, so
it's odd for the permissions code to be deleting and re-creating the
infobars instead of letting them work normally.

This patch makes us leave the PermissionPromptAndroid alone instead of
deleting and re-creating it on switching tabs. While this makes our
model on Android differ from desktop, this lets the permission infobars
be managed normally, and the PermissionPromptAndroid won't need to keep
a reference to the infobar.

This is mostly a revert of https://codereview.chromium.org/2522373002.

BUG=606138
==========

[Timothy Loh, 2017-03-29 06:31:05]

timloh@chromium.org changed reviewers:
+ bauerb@chromium.org, dominickn@chromium.org, dtrainor@chromium.org

[Timothy Loh, 2017-03-29 06:31:06]

Sending to the same folks as were on https://codereview.chromium.org/2522373002
(lshang@ is on another team now and raymes@ is OOO).

[Timothy Loh, 2017-03-29 06:33:12]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 06:33:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 08:06:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 08:06:30]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-03-29 09:05:15]

lgtm

[dominickn, 2017-03-30 02:37:37]

non-OWNER lgtm

[David Trainor- moved to gerrit, 2017-03-30 05:06:16]

lgtm

[Timothy Loh, 2017-03-30 05:41:40]

timloh@chromium.org changed reviewers:
+ benwells@chromium.org

[Timothy Loh, 2017-03-30 05:41:40]

+benwells@ for permissions owners

[benwells, 2017-03-30 08:39:23]

lgtm

[Timothy Loh, 2017-03-31 02:59:07]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-03-31 02:59:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 04:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 04:24:02]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Timothy Loh, 2017-03-31 04:25:05]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-03-31 04:25:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 04:59:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490934305570010,
"parent_rev": "a3c57fc8fb4259c1696333ba4fa01a9fd623e955", "commit_rev":
"f9de5648278de3e68a7c7ef87215a8d3128eb763"}

[commit-bot: I haz the power, 2017-03-31 05:00:04]

Description was changed from

==========
Don't delete the PermissionPromptAndroid when switching tabs

The PermissionRequestManager creates and deletes its PermissionPrompt
when switching to and from a given tab. On desktop this is the mechanism
by which we hide/show permission prompts when switching tabs. On Android
however, we use infobars which already have their visibility managed, so
it's odd for the permissions code to be deleting and re-creating the
infobars instead of letting them work normally.

This patch makes us leave the PermissionPromptAndroid alone instead of
deleting and re-creating it on switching tabs. While this makes our
model on Android differ from desktop, this lets the permission infobars
be managed normally, and the PermissionPromptAndroid won't need to keep
a reference to the infobar.

This is mostly a revert of https://codereview.chromium.org/2522373002.

BUG=606138
==========

to

==========
Don't delete the PermissionPromptAndroid when switching tabs

The PermissionRequestManager creates and deletes its PermissionPrompt
when switching to and from a given tab. On desktop this is the mechanism
by which we hide/show permission prompts when switching tabs. On Android
however, we use infobars which already have their visibility managed, so
it's odd for the permissions code to be deleting and re-creating the
infobars instead of letting them work normally.

This patch makes us leave the PermissionPromptAndroid alone instead of
deleting and re-creating it on switching tabs. While this makes our
model on Android differ from desktop, this lets the permission infobars
be managed normally, and the PermissionPromptAndroid won't need to keep
a reference to the infobar.

This is mostly a revert of https://codereview.chromium.org/2522373002.

BUG=606138

Review-Url: https://codereview.chromium.org/2781803002
Cr-Commit-Position: refs/heads/master@{#461042}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9de5648278de3e68a7c7ef87215...
==========

[commit-bot: I haz the power, 2017-03-31 05:00:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f9de5648278de3e68a7c7ef87215...

[raymes, 2017-04-03 04:28:25]

raymes@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2017-04-03 04:28:25]

https://codereview.chromium.org/2781803002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_request_manager.cc (right):

https://codereview.chromium.org/2781803002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_request_manager.cc:247: void
PermissionRequestManager::DisplayPendingRequests() {
I wonder if we should have NOTREACHED() here on Android too? I'm not sure
though.

[raymes, 2017-04-03 04:30:52]

https://codereview.chromium.org/2781803002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_request_manager.cc (right):

https://codereview.chromium.org/2781803002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_request_manager.cc:247: void
PermissionRequestManager::DisplayPendingRequests() {
On 2017/04/03 04:28:25, raymes (OOO until April 10) wrote:
> I wonder if we should have NOTREACHED() here on Android too? I'm not sure
> though.

Another thought is that I wonder if in the long run we would want to not delete
the view on any platform and instead have the visibility managed from within the
PermissionPrompt subclass?