Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java

Issue 2781803002: Don't delete the PermissionPromptAndroid when switching tabs (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | chrome/browser/permissions/permission_request_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java
index 27605c8d046f2c635f60fbe79dd5011811093ea2..52212441a57f874409c60f01c1c7e02a0a2193b1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java
@@ -8,7 +8,6 @@ import org.chromium.base.ObserverList;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;
-import org.chromium.content_public.browser.WebContents;
import java.util.ArrayList;
import java.util.Collections;
@@ -54,12 +53,6 @@ public abstract class TabModelSelectorBase implements TabModelSelector {
@Override
public void didSelectTab(Tab tab, TabSelectionType type, int lastId) {
notifyChanged();
-
- Tab oldTab = getTabById(lastId);
- if (tab.getId() != lastId) {
- WebContents oldWebContents = (oldTab == null) ? null : oldTab.getWebContents();
- nativeOnActiveTabChanged(oldWebContents, tab.getWebContents());
- }
}
@Override
@@ -249,6 +242,4 @@ public abstract class TabModelSelectorBase implements TabModelSelector {
listener.onNewTabCreated(tab);
}
}
-
- static native void nativeOnActiveTabChanged(WebContents oldContents, WebContents newContents);
}
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | chrome/browser/permissions/permission_request_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698