Don't delete the PermissionPromptAndroid when switching tabs

chrome/browser/permissions/permission_request_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_request_manager.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
@@ skipping 64 matching lines @@
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(PermissionRequestManager);
 
 PermissionRequestManager::PermissionRequestManager(
     content::WebContents* web_contents)
     : content::WebContentsObserver(web_contents),
       view_factory_(base::Bind(&PermissionPrompt::Create)),
       view_(nullptr),
       main_frame_has_fully_loaded_(false),
       persist_(true),
       auto_response_for_test_(NONE),
-      weak_factory_(this) {}
+      weak_factory_(this) {
+#if defined(OS_ANDROID)
+  view_ = view_factory_.Run(web_contents);
+  view_->SetDelegate(this);
+#endif
+}
 
 PermissionRequestManager::~PermissionRequestManager() {
   if (view_ != NULL)
     view_->SetDelegate(NULL);
 
   for (PermissionRequest* request : requests_)
     request->RequestFinished();
   for (PermissionRequest* request : queued_requests_)
     request->RequestFinished();
   for (PermissionRequest* request : queued_frame_requests_)
@@ skipping 121 matching lines @@
       it->second->RequestFinished();
       duplicate_requests_.erase(it);
       return;
     }
   }
 
   NOTREACHED();  // Callers should not cancel requests that are not pending.
 }
 
 void PermissionRequestManager::HideBubble() {
+#if defined(ANDROID)
+  // The infobar system manages infobar lifetime and visibility so don't delete
+  // the PermissionPromptAndroid.
+  NOTREACHED();
+#else
   // Disengage from the existing view if there is one.
   if (!view_)
     return;
 
   view_->SetDelegate(nullptr);
   view_->Hide();
   view_.reset();
+#endif
 }
 
 void PermissionRequestManager::DisplayPendingRequests() {

[raymes, 2017/04/03 04:28:25]

I wonder if we should have NOTREACHED() here on Android too? I'm not sure
though.

[raymes, 2017/04/03 04:30:52]

Another thought is that I wonder if in the long run we would want to not delete
the view on any platform and instead have the visibility managed from within the
PermissionPrompt subclass?

   if (IsBubbleVisible())
     return;
 
   view_ = view_factory_.Run(web_contents());
   view_->SetDelegate(this);
 
   TriggerShowBubble();
 }
 
 void PermissionRequestManager::UpdateAnchorPosition() {
@@ skipping 274 matching lines @@
     case DENY_ALL:
       Deny();
       break;
     case DISMISS:
       Closing();
       break;
     case NONE:
       NOTREACHED();
   }
 }