Don't delete the PermissionPromptAndroid when switching tabs

chrome/browser/permissions/permission_request_manager.cc

Index: chrome/browser/permissions/permission_request_manager.cc
diff --git a/chrome/browser/permissions/permission_request_manager.cc b/chrome/browser/permissions/permission_request_manager.cc
index 9b55f72a9fff48d800e995b4526b556d5fae94aa..35dc5ec81178ca42bd930191532b08c440efbb6b 100644
--- a/chrome/browser/permissions/permission_request_manager.cc
+++ b/chrome/browser/permissions/permission_request_manager.cc
@@ -82,7 +82,12 @@ PermissionRequestManager::PermissionRequestManager(
       main_frame_has_fully_loaded_(false),
       persist_(true),
       auto_response_for_test_(NONE),
-      weak_factory_(this) {}
+      weak_factory_(this) {
+#if defined(OS_ANDROID)
+  view_ = view_factory_.Run(web_contents);
+  view_->SetDelegate(this);
+#endif
+}
 
 PermissionRequestManager::~PermissionRequestManager() {
   if (view_ != NULL)
@@ -224,6 +229,11 @@ void PermissionRequestManager::CancelRequest(PermissionRequest* request) {
 }
 
 void PermissionRequestManager::HideBubble() {
+#if defined(ANDROID)
+  // The infobar system manages infobar lifetime and visibility so don't delete
+  // the PermissionPromptAndroid.
+  NOTREACHED();
+#else
   // Disengage from the existing view if there is one.
   if (!view_)
     return;
@@ -231,6 +241,7 @@ void PermissionRequestManager::HideBubble() {
   view_->SetDelegate(nullptr);
   view_->Hide();
   view_.reset();
+#endif
 }
 
 void PermissionRequestManager::DisplayPendingRequests() {

[raymes, 2017/04/03 04:28:25]

I wonder if we should have NOTREACHED() here on Android too? I'm not sure
though.

[raymes, 2017/04/03 04:30:52]

Another thought is that I wonder if in the long run we would want to not delete
the view on any platform and instead have the visibility managed from within the
PermissionPrompt subclass?