Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2707963002: [ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+watch_chromium.org, jdonnelly+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC. Automatically generated ARCMigrate commit Notable issues: * added some __bridge casts * put some __weak and __unsafe_unretained classifiers in headers BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2707963002 Cr-Commit-Position: refs/heads/master@{#459107} Committed: https://chromium.googlesource.com/chromium/src/+/3da3338bfc027c0b7a48e5b033feb04f24792b17

Patch Set 1 #

Patch Set 2 : weaks #

Total comments: 21

Patch Set 3 : comments/rebase #

Patch Set 4 : rebase #

Patch Set 5 : ARC in new code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -152 lines) Patch
M ios/chrome/browser/ui/omnibox/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/location_bar_view_ios.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.h View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm View 1 2 3 4 12 chunks +17 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.mm View 3 chunks +7 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm View 1 2 21 chunks +55 lines, -63 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_view_ios.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm View 1 2 3 3 chunks +7 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/page_info_view_controller.h View 1 2 1 chunk +2 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/page_info_view_controller.mm View 1 2 3 14 chunks +30 lines, -26 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/truncating_attributed_label.mm View 1 2 3 4 6 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 35 (25 generated)
stkhapugin
PTAL
3 years, 10 months ago (2017-02-20 17:27:46 UTC) #6
rohitrao (ping after 24h)
https://codereview.chromium.org/2707963002/diff/20001/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h File ios/chrome/browser/ui/omnibox/location_bar_view_ios.h (right): https://codereview.chromium.org/2707963002/diff/20001/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h#newcode111 ios/chrome/browser/ui/omnibox/location_bar_view_ios.h:111: base::scoped_nsobject<OmniboxClearButtonBridge> clear_button_bridge_; We have to use scoped_nsobject here, because ...
3 years, 10 months ago (2017-02-24 13:40:32 UTC) #10
Justin Donnelly
https://codereview.chromium.org/2707963002/diff/20001/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm File ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm (right): https://codereview.chromium.org/2707963002/diff/20001/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm#newcode690 ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm:690: dictionaryWithObjectsAndKeys:(__bridge id)fontRef, On 2017/02/24 13:40:31, rohitrao wrote: > There's ...
3 years, 10 months ago (2017-02-24 15:40:39 UTC) #12
stkhapugin
thanks, ptal https://codereview.chromium.org/2707963002/diff/20001/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h File ios/chrome/browser/ui/omnibox/location_bar_view_ios.h (right): https://codereview.chromium.org/2707963002/diff/20001/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h#newcode111 ios/chrome/browser/ui/omnibox/location_bar_view_ios.h:111: base::scoped_nsobject<OmniboxClearButtonBridge> clear_button_bridge_; On 2017/02/24 13:40:31, rohitrao wrote: ...
3 years, 9 months ago (2017-03-01 17:43:59 UTC) #13
stkhapugin
ping
3 years, 9 months ago (2017-03-10 12:08:24 UTC) #18
stkhapugin
ping
3 years, 9 months ago (2017-03-21 17:29:34 UTC) #27
stkhapugin
-rohitrao +marq PTAL
3 years, 9 months ago (2017-03-23 12:41:35 UTC) #29
marq (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-23 15:15:43 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707963002/80001
3 years, 9 months ago (2017-03-23 15:18:44 UTC) #32
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 16:20:43 UTC) #35
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3da3338bfc027c0b7a48e5b033fe...

Powered by Google App Engine
This is Rietveld 408576698