Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: ios/chrome/browser/ui/omnibox/page_info_view_controller.h

Issue 2707963002: [ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC. (Closed)
Patch Set: ARC in new code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/omnibox/page_info_view_controller.h
diff --git a/ios/chrome/browser/ui/omnibox/page_info_view_controller.h b/ios/chrome/browser/ui/omnibox/page_info_view_controller.h
index 8965ea21233bf5886d7526f7682ab921893fa0eb..50fb2307bc1ec7a0e7d1955cdf0cca3b94f3b2dc 100644
--- a/ios/chrome/browser/ui/omnibox/page_info_view_controller.h
+++ b/ios/chrome/browser/ui/omnibox/page_info_view_controller.h
@@ -53,16 +53,9 @@ class PageInfoModelBubbleBridge : public PageInfoModelObserver {
}
private:
- void PerformLayout() {
- // If the window is animating closed when this is called, the
- // animation could be holding the last reference to |controller_|
- // (and thus |this|). Pin it until the task is completed.
- base::scoped_nsobject<PageInfoViewController> keep_alive(
- [controller_ retain]);
- [controller_ performLayout];
- }
+ void PerformLayout();
- PageInfoViewController* controller_; // weak
+ __unsafe_unretained PageInfoViewController* controller_;
base::WeakPtrFactory<PageInfoModelBubbleBridge> weak_ptr_factory_;
« no previous file with comments | « ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm ('k') | ios/chrome/browser/ui/omnibox/page_info_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698