Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

Issue 2707963002: [ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC. (Closed)
Patch Set: ARC in new code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
diff --git a/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm b/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
index df811ce24d8a4a10609c8c54649e77fba729a0cb..63d836278dfd723d033dc73c241cd274a935b509 100644
--- a/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
+++ b/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
@@ -38,6 +38,10 @@
#include "ui/gfx/color_palette.h"
#include "ui/gfx/image/image.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
using base::UserMetricsAction;
namespace {
@@ -171,7 +175,7 @@ OmniboxViewIOS::OmniboxViewIOS(OmniboxTextFieldIOS* field,
controller,
base::MakeUnique<ChromeOmniboxClientIOS>(controller, browser_state)),
browser_state_(browser_state),
- field_([field retain]),
+ field_(field),
controller_(controller),
preloader_(preloader),
ignore_popup_updates_(false),
@@ -684,8 +688,8 @@ void OmniboxViewIOS::UpdateSchemeStyle(const gfx::Range& range) {
NSAttributedString* OmniboxViewIOS::ApplyTextAttributes(
const base::string16& text) {
- NSMutableAttributedString* as = [[[NSMutableAttributedString alloc]
- initWithString:base::SysUTF16ToNSString(text)] autorelease];
+ NSMutableAttributedString* as = [[NSMutableAttributedString alloc]
+ initWithString:base::SysUTF16ToNSString(text)];
// Cache a pointer to the attributed string to allow the superclass'
// virtual method invocations to add attributes.
DCHECK(attributing_display_string_ == nil);
« no previous file with comments | « ios/chrome/browser/ui/omnibox/omnibox_view_ios.h ('k') | ios/chrome/browser/ui/omnibox/page_info_view_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698