service_manager: More consistent Service lifecycle API

service_manager: More consistent Service lifecycle API

Renames OnStop() to a more accurate OnServiceManagerConnectionLost()
and clarifies the meaning and usage in the documentation.

Ensures that Service::context() is always valid after the constructor
rather than only after OnStart().

Renames SetConnectionLostClosure to SetQuitClosure to reflect
its actual meaning.

Removes the unused DestroyService() API.

BUG=672614
R=sky@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=xhwang@chromium.org for rename in media

Review-Url: https://codereview.chromium.org/2701883002
Cr-Commit-Position: refs/heads/master@{#451453}
Committed: https://chromium.googlesource.com/chromium/src/+/1033a629e2246612bf9c8b37b3400db53f53133e

[Ken Rockot(use gerrit already), 2017-02-17 18:44:46]

Description was changed from

==========
service_manager: More consistent Service lifecycle API

Renames OnStop() to a more accurate OnServiceManagerConnectionLost()
and clarifies the meaning and usage in the documentation.

Ensures that Service::context() is always valid after the constructor
rather than only after OnStart().

Renames SetConnectionLostClosure to SetQuitClosure to reflect
its actual meaning.

Removes the unused DestroyService() API.

BUG=672614
R=sky@chromium.org
==========

to

==========
service_manager: More consistent Service lifecycle API

Renames OnStop() to a more accurate OnServiceManagerConnectionLost()
and clarifies the meaning and usage in the documentation.

Ensures that Service::context() is always valid after the constructor
rather than only after OnStart().

Renames SetConnectionLostClosure to SetQuitClosure to reflect
its actual meaning.

Removes the unused DestroyService() API.

BUG=672614
R=sky@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Ken Rockot(use gerrit already), 2017-02-17 18:44:48]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 18:45:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-17 18:47:58]

PTAL. I ended up leaving the bool return value for now, because I don't like an
enum return value much better and want to consider other more involved options
separately.

[Ken Rockot(use gerrit already), 2017-02-17 18:48:21]

Description was changed from

==========
service_manager: More consistent Service lifecycle API

Renames OnStop() to a more accurate OnServiceManagerConnectionLost()
and clarifies the meaning and usage in the documentation.

Ensures that Service::context() is always valid after the constructor
rather than only after OnStart().

Renames SetConnectionLostClosure to SetQuitClosure to reflect
its actual meaning.

Removes the unused DestroyService() API.

BUG=672614
R=sky@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
service_manager: More consistent Service lifecycle API

Renames OnStop() to a more accurate OnServiceManagerConnectionLost()
and clarifies the meaning and usage in the documentation.

Ensures that Service::context() is always valid after the constructor
rather than only after OnStart().

Renames SetConnectionLostClosure to SetQuitClosure to reflect
its actual meaning.

Removes the unused DestroyService() API.

BUG=672614
R=sky@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=xhwang@chromium.org for rename in media
==========

[commit-bot: I haz the power, 2017-02-17 19:03:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:03:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ken Rockot(use gerrit already), 2017-02-17 19:06:58]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 19:54:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:54:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-02-17 20:10:50]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 20:11:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 20:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:27:46]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2017-02-17 20:36:58]

LGTM

[Ken Rockot(use gerrit already), 2017-02-17 21:20:16]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 21:20:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:09:27]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ken Rockot(use gerrit already), 2017-02-18 09:58:29]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-02-18 09:58:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 11:03:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487411909804310,
"parent_rev": "905e389f8130659ead4b44dad07f976605622025", "commit_rev":
"1033a629e2246612bf9c8b37b3400db53f53133e"}

[commit-bot: I haz the power, 2017-02-18 11:04:18]

Description was changed from

==========
service_manager: More consistent Service lifecycle API

Renames OnStop() to a more accurate OnServiceManagerConnectionLost()
and clarifies the meaning and usage in the documentation.

Ensures that Service::context() is always valid after the constructor
rather than only after OnStart().

Renames SetConnectionLostClosure to SetQuitClosure to reflect
its actual meaning.

Removes the unused DestroyService() API.

BUG=672614
R=sky@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=xhwang@chromium.org for rename in media
==========

to

==========
service_manager: More consistent Service lifecycle API

Renames OnStop() to a more accurate OnServiceManagerConnectionLost()
and clarifies the meaning and usage in the documentation.

Ensures that Service::context() is always valid after the constructor
rather than only after OnStart().

Renames SetConnectionLostClosure to SetQuitClosure to reflect
its actual meaning.

Removes the unused DestroyService() API.

BUG=672614
R=sky@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=xhwang@chromium.org for rename in media

Review-Url: https://codereview.chromium.org/2701883002
Cr-Commit-Position: refs/heads/master@{#451453}
Committed:
https://chromium.googlesource.com/chromium/src/+/1033a629e2246612bf9c8b37b340...
==========

[commit-bot: I haz the power, 2017-02-18 11:04:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1033a629e2246612bf9c8b37b340...