media/mojo/services/media_service.h - Issue 2701883002: service_manager: More consistent Service lifecycle API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/media_service.h

Issue 2701883002: service_manager: More consistent Service lifecycle API (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mojo/services/media_service.h

diff --git a/media/mojo/services/media_service.h b/media/mojo/services/media_service.h

index de2b0da96919b19532268a12a5371326ec50a361..08c4885c51c433a84779ffff7c7fed8cf4d3e78d 100644

--- a/media/mojo/services/media_service.h

+++ b/media/mojo/services/media_service.h

@@ -41,7 +41,7 @@ class MEDIA_MOJO_EXPORT MediaService

void OnStart() final;

bool OnConnect(const service_manager::ServiceInfo& remote_info,

service_manager::InterfaceRegistry* registry) final;

- bool OnStop() final;

+ bool OnServiceManagerConnectionLost() final;

// service_manager::InterfaceFactory<mojom::MediaService> implementation.

void Create(const service_manager::Identity& remote_identity,