Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: chrome/app/mash/mash_runner.cc

Issue 2701883002: service_manager: More consistent Service lifecycle API (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/base/mash_browser_tests_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/mash/mash_runner.cc
diff --git a/chrome/app/mash/mash_runner.cc b/chrome/app/mash/mash_runner.cc
index 9c14e731f709ac6b513efa181e00b63c28d5fc2a..d5086ec61003d95db27dc5df9b8bf95cdd6fc551 100644
--- a/chrome/app/mash/mash_runner.cc
+++ b/chrome/app/mash/mash_runner.cc
@@ -237,8 +237,8 @@ void MashRunner::StartChildApp(
service_manager::ServiceContext context(
base::MakeUnique<mash::MashPackagedService>(),
std::move(service_request));
- // Quit the child process if it loses its connection to service manager.
- context.SetConnectionLostClosure(run_loop.QuitClosure());
+ // Quit the child process when the service quits.
+ context.SetQuitClosure(run_loop.QuitClosure());
run_loop.Run();
// |context| must be destroyed before |message_loop|.
}
« no previous file with comments | « no previous file | chrome/test/base/mash_browser_tests_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698