content/common/service_manager/service_manager_connection_impl.cc - Issue 2701883002: service_manager: More consistent Service lifecycle API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_manager/service_manager_connection_impl.cc

Issue 2701883002: service_manager: More consistent Service lifecycle API (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/service_manager/service_manager_connection_impl.cc

diff --git a/content/common/service_manager/service_manager_connection_impl.cc b/content/common/service_manager/service_manager_connection_impl.cc

index 8be6e76bb4f4390d97471174afd4a1215dc0db6f..83a4d1124d94734a7ea3d8644d879ef836078503 100644

--- a/content/common/service_manager/service_manager_connection_impl.cc

+++ b/content/common/service_manager/service_manager_connection_impl.cc

@@ -273,7 +273,7 @@ class ServiceManagerConnectionImpl::IOThreadContext

return accept;

}

- bool OnStop() override {

+ bool OnServiceManagerConnectionLost() override {

ClearConnectionFiltersOnIOThread();

callback_task_runner_->PostTask(FROM_HERE, stop_callback_);

return true;