content/common/service_manager/embedded_service_runner.cc - Issue 2701883002: service_manager: More consistent Service lifecycle API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_manager/embedded_service_runner.cc

Issue 2701883002: service_manager: More consistent Service lifecycle API (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/service_manager/embedded_service_runner.cc

diff --git a/content/common/service_manager/embedded_service_runner.cc b/content/common/service_manager/embedded_service_runner.cc

index 0c7c45890da1eb08815a88162394c6fd70744953..665a6e388b3569a4996daccbc6f23c4c99d4f9f5 100644

--- a/content/common/service_manager/embedded_service_runner.cc

+++ b/content/common/service_manager/embedded_service_runner.cc

@@ -87,7 +87,7 @@ class EmbeddedServiceRunner::InstanceManager

factory_callback_.Run(), std::move(request));

service_manager::ServiceContext* raw_context = context.get();

- context->SetConnectionLostClosure(

+ context->SetQuitClosure(

base::Bind(&InstanceManager::OnInstanceLost, this, instance_id));

contexts_.insert(std::make_pair(raw_context, std::move(context)));

id_to_context_map_.insert(std::make_pair(instance_id, raw_context));