Include 'external' policies in grit output (admx, adm, doc etc.)

Include 'external' policies in grit output (admx, adm, doc etc.)

External-type policies consist of a URL and a SHA-256 hash.
Right now, they can only be set through cloud policy, but not,
for instance, through Active Directory. This CL allows that.
Admins will have to calculate the SHA-256 hash of the URL
themselves, e.g. using some widely available tools, and then
specify the URL together with the hash as a JSON string.

{ "url": "<url>", "hash": "<SHA-256 hash>" }

Right now, all external-type policies are Chrome OS-only, so that
none of them shows up in ADMX templates, but this will change when
Chrome OS specific ADMX templates are generated, see
https://codereview.chromium.org/2481183002/.

BUG=638560
TEST=Compiled, ran tests, temporarily modified an external-type policy to
support all platforms, generated templates for all platforms, checked
output in text editor, loaded ADMX templates into Active Directory tools.

Review-Url: https://chromiumcodereview.appspot.com/2653823006
Cr-Commit-Position: refs/heads/master@{#503451}
Committed: https://chromium.googlesource.com/chromium/src/+/46a334169f967102881de54282c993a33641e658

[ljusten (tachyonic), 2017-01-26 09:55:08]

ljusten@chromium.org changed reviewers:
+ bartfab@chromium.org, thakis@chromium.org

[ljusten (tachyonic), 2017-01-26 09:55:08]

We'd like to support the 3 'external' policies (avatar image and device/user
wallpaper) we have right now for Chromad (Active Directory (AD) enrollment of
Chromebooks), which means they'd have to be in ADMX templates. This CL enables
that. Talked to bartfab@ briefly, who originally wrote this, he's OK with it.

The policies are not respected right now in AD mode, but that's a different
issue.

[bartfab (slow), 2017-02-13 13:39:00]

lgtm

https://codereview.chromium.org/2653823006/diff/1/tools/grit/grit/format/poli...
File tools/grit/grit/format/policy_templates/writers/json_writer.py (left):

https://codereview.chromium.org/2653823006/diff/1/tools/grit/grit/format/poli...
tools/grit/grit/format/policy_templates/writers/json_writer.py:47: # This type
can only be set through cloud policy.
Will you make this code path work as well, external policy data set via JSON on
Chrome OS? This is only a debugging tool, not officially supported, but we
should only enable template generation here if you are actually planning to wire
it up.

[Nico, 2017-02-13 15:39:31]

tests?

[ljusten (tachyonic), 2017-02-21 09:52:45]

Nico, PTAL.

https://codereview.chromium.org/2653823006/diff/1/tools/grit/grit/format/poli...
File tools/grit/grit/format/policy_templates/writers/json_writer.py (left):

https://codereview.chromium.org/2653823006/diff/1/tools/grit/grit/format/poli...
tools/grit/grit/format/policy_templates/writers/json_writer.py:47: # This type
can only be set through cloud policy.
On 2017/02/13 13:39:00, bartfab (slow) wrote:
> Will you make this code path work as well, external policy data set via JSON
on
> Chrome OS? This is only a debugging tool, not officially supported, but we
> should only enable template generation here if you are actually planning to
wire
> it up.

I'm not sure what you are referring to. Are you referring to the JSON files
loaded from e.g. /etc/opt/chrome/policies? It's not planned to wire it up, but I
can take a look.

The plan is to wire up the policies for AD-enrolled Chromebooks. Right now, it
only seems to work for Google-enrolled devices.

[ljusten (tachyonic), 2017-04-12 08:42:25]

The CQ bit was checked by ljusten@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 08:42:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 08:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 08:52:50]

Dry run: This issue passed the CQ dry run.

[ljusten (tachyonic), 2017-06-30 14:06:38]

ljusten@chromium.org changed reviewers:
+ vapier@chromium.org, wad@chromium.org

[ljusten (tachyonic), 2017-06-30 14:06:39]

Trying to see if peeps are on vacation, please ignore.

[ljusten (tachyonic), 2017-06-30 14:07:06]

ljusten@chromium.org changed reviewers:
- vapier@chromium.org, wad@chromium.org

[ljusten (tachyonic), 2017-06-30 14:07:07]

Nevermind

[Nico, 2017-06-30 14:11:05]

You can check https://c/username to see vacation calendars

On Jun 30, 2017 10:07 AM, <ljusten@chromium.org> wrote:

> Nevermind
>
> https://codereview.chromium.org/2653823006/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ljusten (tachyonic), 2017-09-21 14:53:00]

ljusten@chromium.org changed reviewers:
- thakis@chromium.org

[ljusten (tachyonic), 2017-09-21 14:53:01]

I'll add support for Linux external policies in a follow-up CL.

[ljusten (tachyonic), 2017-09-21 14:53:21]

The CQ bit was checked by ljusten@chromium.org

[ljusten (tachyonic), 2017-09-21 14:53:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bartfab@chromium.org
Link to the patchset: https://codereview.chromium.org/2653823006/#ps120001
(title: "Whitespace fix")

[commit-bot: I haz the power, 2017-09-21 14:53:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-21 15:13:09]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1506005601047580,
"parent_rev": "97f565d0defea8b8bf0bf2e958ba63df8e60be5e", "commit_rev":
"46a334169f967102881de54282c993a33641e658"}

[commit-bot: I haz the power, 2017-09-21 15:13:24]

Description was changed from

==========
Include 'external' policies in grit output (admx, adm, doc etc.)

External-type policies consist of a URL and a SHA-256 hash.
Right now, they can only be set through cloud policy, but not,
for instance, through Active Directory. This CL allows that.
Admins will have to calculate the SHA-256 hash of the URL
themselves, e.g. using some widely available tools, and then
specify the URL together with the hash as a JSON string.

{ "url": "<url>", "hash": "<SHA-256 hash>" }

Right now, all external-type policies are Chrome OS-only, so that
none of them shows up in ADMX templates, but this will change when
Chrome OS specific ADMX templates are generated, see
https://codereview.chromium.org/2481183002/.

BUG=638560
TEST=Compiled, ran tests, temporarily modified an external-type policy to
support all platforms, generated templates for all platforms, checked
output in text editor, loaded ADMX templates into Active Directory tools.
==========

to

==========
Include 'external' policies in grit output (admx, adm, doc etc.)

External-type policies consist of a URL and a SHA-256 hash.
Right now, they can only be set through cloud policy, but not,
for instance, through Active Directory. This CL allows that.
Admins will have to calculate the SHA-256 hash of the URL
themselves, e.g. using some widely available tools, and then
specify the URL together with the hash as a JSON string.

{ "url": "<url>", "hash": "<SHA-256 hash>" }

Right now, all external-type policies are Chrome OS-only, so that
none of them shows up in ADMX templates, but this will change when
Chrome OS specific ADMX templates are generated, see
https://codereview.chromium.org/2481183002/.

BUG=638560
TEST=Compiled, ran tests, temporarily modified an external-type policy to
support all platforms, generated templates for all platforms, checked
output in text editor, loaded ADMX templates into Active Directory tools.

Review-Url: https://chromiumcodereview.appspot.com/2653823006
Cr-Commit-Position: refs/heads/master@{#503451}
Committed:
https://chromium.googlesource.com/chromium/src/+/46a334169f967102881de54282c9...
==========

[commit-bot: I haz the power, 2017-09-21 15:13:26]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/46a334169f967102881de54282c9...