Include 'external' policies in grit output (admx, adm, doc etc.)

components/policy/tools/template_writers/writers/adml_writer.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from xml.dom import minidom
 from writers import xml_formatted_writer
 import re
 
 
@@ skipping 70 matching lines @@
     else:
       policy_label = policy_name
 
     self._AddString(policy_name, policy_caption)
     self._AddString(policy_name + '_Explain', policy_description)
     presentation_elem = self.AddElement(
         self._presentation_table_elem, 'presentation', {'id': policy_name})
 
     if policy_type == 'main':
       pass
-    elif policy_type in ('string', 'dict'):
-      # 'dict' policies are configured as JSON-encoded strings on Windows.
+    elif policy_type in ('string', 'dict', 'external'):
+      # 'dict' and 'external' policies are configured as JSON-encoded strings on
+      # Windows.
       textbox_elem = self.AddElement(presentation_elem, 'textBox',
                                      {'refId': policy_name})
       label_elem = self.AddElement(textbox_elem, 'label')
       label_elem.appendChild(self._doc.createTextNode(policy_label))
     elif policy_type == 'int':
       textbox_elem = self.AddElement(presentation_elem, 'decimalTextBox',
                                      {'refId': policy_name})
       textbox_elem.appendChild(self._doc.createTextNode(policy_label + ':'))
     elif policy_type in ('int-enum', 'string-enum'):
       for item in policy['items']:
         self._AddString(policy_name + "_" + item['name'], item['caption'])
       dropdownlist_elem = self.AddElement(presentation_elem, 'dropdownList',
                                           {'refId': policy_name})
       dropdownlist_elem.appendChild(self._doc.createTextNode(policy_label))
     elif policy_type in ('list', 'string-enum-list'):
       self._AddString(policy_name + 'Desc', policy_caption)
       listbox_elem = self.AddElement(presentation_elem, 'listBox',
                                      {'refId': policy_name + 'Desc'})
       listbox_elem.appendChild(self._doc.createTextNode(policy_label))
     elif policy_type == 'group':
       pass
-    elif policy_type == 'external':
-      # This type can only be set through cloud policy.
-      pass
     else:
       raise Exception('Unknown policy type %s.' % policy_type)
 
   def BeginPolicyGroup(self, group):
     '''Generates ADML elements for a Policy-Group. For each Policy-Group two
     ADML "string" elements are added to the string-table. One contains the
     caption of the Policy-Group and the other a description. A Policy-Group also
     requires an ADML "presentation" element that must be added to the
     presentation-table. The "presentation" element is the container for the
     elements that define the visual presentation of the Policy-Goup's Policies.
@@ skipping 50 matching lines @@
     assert len(self.platforms) == 1
     self.winconfig = self.config['win_config'][self.platforms[0]]
 
   def GetTemplateText(self):
     # Using "toprettyxml()" confuses the Windows Group Policy Editor
     # (gpedit.msc) because it interprets whitespace characters in text between
     # the "string" tags. This prevents gpedit.msc from displaying the category
     # names correctly.
     # TODO(markusheintz): Find a better formatting that works with gpedit.
     return self._doc.toxml()