components/policy/tools/template_writers/writers/plist_strings_writer.py - Issue 2653823006: Include 'external' policies in grit output (admx, adm, doc etc.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/tools/template_writers/writers/plist_strings_writer.py

Issue 2653823006: Include 'external' policies in grit output (admx, adm, doc etc.) (Closed)

Patch Set: Whitespace fix Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/tools/template_writers/writers/json_writer_unittest.py ('k') | components/policy/tools/template_writers/writers/plist_writer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/tools/template_writers/writers/plist_strings_writer.py

diff --git a/components/policy/tools/template_writers/writers/plist_strings_writer.py b/components/policy/tools/template_writers/writers/plist_strings_writer.py

index 45cfdb7b70605c48fd1dbecc22371caafb5babbf..49344686d06dd642aba32b2620cd34e84d20d6a3 100755

--- a/components/policy/tools/template_writers/writers/plist_strings_writer.py

+++ b/components/policy/tools/template_writers/writers/plist_strings_writer.py

@@ -52,10 +52,7 @@ class PListStringsWriter(template_writer.TemplateWriter):

string table.

'''

desc = policy['desc']

- if policy['type'] == 'external':

- # This type can only be set through cloud policy.

- return

- elif policy['type'] in ('int-enum','string-enum', 'string-enum-list'):

+ if policy['type'] in ('int-enum','string-enum', 'string-enum-list'):

# Append the captions of enum items to the description string.

item_descs = []

for item in policy['items']: