Include 'external' policies in grit output (admx, adm, doc etc.)

components/policy/tools/template_writers/writers/admx_writer.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from xml.dom import minidom
 from writers import xml_formatted_writer
 
 
 def GetWriter(config):
@@ skipping 108 matching lines @@
     }
     category_elem = self.AddElement(parent, 'category', attributes)
     if parent_category_name:
       attributes = {'ref': parent_category_name}
       self.AddElement(category_elem, 'parentCategory', attributes)
 
   def _AddCategories(self, categories):
     '''Generates the ADMX "categories" element and adds it to the categories
     main node. The "categories" element defines the category for the policies
     defined in this ADMX document. Here is an example of an ADMX "categories"
-    element on Windows:
+    element:
 
     <categories>
       <category displayName="$(string.googlechrome)" name="googlechrome">
         <parentCategory ref="Google:Cat_Google"/>
       </category>
     </categories>
 
     Args:
       categories_path: The categories path e.g. ['google', 'googlechrome']. For
         each level in the path a "category" element will be generated, unless
@@ skipping 124 matching lines @@
       raise Exception('There is supposed to be only one "elements" node but'
                       ' there are %s.' % str(len(elements_list)))
 
   def _WritePolicy(self, policy, name, key, parent):
     '''Generates AMDX elements for a Policy. There are four different policy
     types: Main-Policy, String-Policy, Enum-Policy and List-Policy.
     '''
     policies_elem = self._active_policies_elem
     policy_type = policy['type']
     policy_name = policy['name']
-    if policy_type == 'external':
-      # This type can only be set through cloud policy.
-      return
 
     attributes = {
       'name': name,
       'class': self.GetClass(policy),
       'displayName': self._AdmlString(policy_name),
       'explainText': self._AdmlStringExplain(policy_name),
       'presentation': self._AdmlPresentation(policy_name),
       'key': key,
     }
     # Store the current "policy" AMDX element in self for later use by the
     # WritePolicy method.
     policy_elem = self.AddElement(policies_elem, 'policy',
                                   attributes)
     self.AddElement(policy_elem, 'parentCategory',
                     {'ref': parent})
     self.AddElement(policy_elem, 'supportedOn',
                     {'ref': self.config['win_supported_os']})
     if policy_type == 'main':
       self.AddAttribute(policy_elem, 'valueName', policy_name)
       self._AddMainPolicy(policy_elem)
-    elif policy_type in ('string', 'dict'):
-      # 'dict' policies are configured as JSON-encoded strings on Windows.
+    elif policy_type in ('string', 'dict', 'external'):
+      # 'dict' and 'external' policies are configured as JSON-encoded strings on
+      # Windows.
       parent = self._GetElements(policy_elem)
       self._AddStringPolicy(parent, policy_name)
     elif policy_type == 'int':
       parent = self._GetElements(policy_elem)
       self._AddIntPolicy(parent, policy_name)
     elif policy_type in ('int-enum', 'string-enum'):
       parent = self._GetElements(policy_elem)
       self._AddEnumPolicy(parent, policy)
     elif policy_type in ('list', 'string-enum-list'):
       parent = self._GetElements(policy_elem)
@@ skipping 82 matching lines @@
     self._active_mandatory_policy_group_name = \
         self.winconfig['mandatory_category_path'][-1]
     self._active_recommended_policy_group_name = \
         self.winconfig['recommended_category_path'][-1]
 
   def GetTemplateText(self):
     return self.ToPrettyXml(self._doc)
 
   def GetClass(self, policy):
     return 'Both'