Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2566783002: Various formatting cleanups to net/quic/crypto and net/quic/congestion_control (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Various formatting cleanups to net/quic/crypto and net/quic/congestion_control. Committed: https://crrev.com/faf834e52b98d7de80e54c104bb75007788d0018 Cr-Commit-Position: refs/heads/master@{#440145}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : WIP #

Patch Set 4 : Rebase #

Patch Set 5 : ~ #

Patch Set 6 : More #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -764 lines) Patch
M net/http/disk_cache_based_quic_server_info.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/disk_cache_based_quic_server_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gypi View 1 2 3 4 5 6 6 chunks +5 lines, -5 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + net/quic/chromium/properties_based_quic_server_info.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + net/quic/chromium/properties_based_quic_server_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/quic/chromium/properties_based_quic_server_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + net/quic/chromium/quic_server_info.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + net/quic/chromium/quic_server_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.cc View 1 2 3 4 5 6 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/core/crypto/aes_128_gcm_12_decrypter.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/aes_128_gcm_12_decrypter_test.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/aes_128_gcm_12_encrypter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_decrypter.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_decrypter_test.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_encrypter.h View 2 chunks +3 lines, -6 lines 0 comments Download
M net/quic/core/crypto/channel_id.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/channel_id_test.cc View 1 2 2 chunks +65 lines, -19 lines 0 comments Download
M net/quic/core/crypto/common_cert_set_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/crypto_framer.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/crypto_framer.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/crypto_handshake.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/crypto/crypto_handshake_message.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_handshake_message.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/crypto/crypto_handshake_message_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/crypto_protocol.h View 1 2 3 4 5 6 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_secret_boxer.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_secret_boxer_test.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/crypto/crypto_server_config_protobuf.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 1 2 3 4 5 6 4 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_utils.h View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_utils_test.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/curve25519_key_exchange_test.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/local_strike_register_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/null_decrypter.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/null_decrypter.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/null_encrypter.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/p256_key_exchange.h View 2 chunks +2 lines, -4 lines 0 comments Download
M net/quic/core/crypto/p256_key_exchange.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/core/crypto/p256_key_exchange_test.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/proof_source.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/proof_source.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
D net/quic/core/crypto/properties_based_quic_server_info.h View 1 chunk +0 lines, -64 lines 0 comments Download
D net/quic/core/crypto/properties_based_quic_server_info.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D net/quic/core/crypto/properties_based_quic_server_info_test.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M net/quic/core/crypto/quic_compressed_certs_cache.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_compressed_certs_cache_test.cc View 1 2 3 4 5 6 3 chunks +4 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.h View 1 2 3 4 5 6 3 chunks +4 lines, -3 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 1 2 3 4 5 6 2 chunks +2 lines, -5 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config_test.cc View 1 2 3 4 5 6 4 chunks +3 lines, -7 lines 0 comments Download
M net/quic/core/crypto/quic_decrypter.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/quic_encrypter.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/quic_random.h View 1 chunk +2 lines, -2 lines 0 comments Download
D net/quic/core/crypto/quic_server_info.h View 1 2 3 4 5 6 1 chunk +0 lines, -178 lines 0 comments Download
D net/quic/core/crypto/quic_server_info.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M net/quic/core/crypto/strike_register.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 2 3 4 5 6 1 chunk +0 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (17 generated)
Ryan Hamilton
4 years ago (2016-12-15 19:27:55 UTC) #10
Zhongyi Shi
lgtm! You will need to update the cl description and title to remove internal info.
4 years ago (2016-12-16 01:00:19 UTC) #11
Ryan Hamilton
On 2016/12/16 01:00:19, Zhongyi Shi wrote: > lgtm! > > You will need to update ...
4 years ago (2016-12-16 01:45:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566783002/100001
4 years ago (2016-12-16 01:46:31 UTC) #15
commit-bot: I haz the power
Failed to apply patch for net/quic/core/crypto/curve25519_key_exchange.h: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-16 05:59:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566783002/120001
4 years ago (2016-12-21 16:28:54 UTC) #20
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years ago (2016-12-21 17:55:43 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-21 18:00:16 UTC) #25
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/faf834e52b98d7de80e54c104bb75007788d0018
Cr-Commit-Position: refs/heads/master@{#440145}

Powered by Google App Engine
This is Rietveld 408576698