Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2590313003: Use SHA-1 functions from BoringSSL directly. (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SHA-1 functions from BoringSSL directly. This makes internal and Chromium versions more similar by using the same API. Merge internal change: 142672853 Committed: https://crrev.com/3ad2c5801c6f3a6af07ffbdd6c41e0e00cc18cc4 Cr-Commit-Position: refs/heads/master@{#440168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M net/quic/test_tools/quic_test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_test_utils_test.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/test_tools/simulator/quic_endpoint.cc View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Ryan Hamilton
4 years ago (2016-12-21 17:47:19 UTC) #2
Zhongyi Shi
lgtm
4 years ago (2016-12-21 18:08:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590313003/1
4 years ago (2016-12-21 18:12:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 18:56:40 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-21 18:58:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ad2c5801c6f3a6af07ffbdd6c41e0e00cc18cc4
Cr-Commit-Position: refs/heads/master@{#440168}

Powered by Google App Engine
This is Rietveld 408576698