Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: net/quic/core/crypto/crypto_utils_test.cc

Issue 2566783002: Various formatting cleanups to net/quic/crypto and net/quic/congestion_control (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/crypto/crypto_utils.h" 5 #include "net/quic/core/crypto/crypto_utils.h"
6 6
7 #include "net/quic/core/quic_utils.h"
7 #include "net/quic/test_tools/quic_test_utils.h" 8 #include "net/quic/test_tools/quic_test_utils.h"
8 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
9 10
10 using std::string; 11 using std::string;
11 12
12 namespace net { 13 namespace net {
13 namespace test { 14 namespace test {
14 namespace { 15 namespace {
15 16
16 TEST(CryptoUtilsTest, IsValidSNI) { 17 TEST(CryptoUtilsTest, IsValidSNI) {
17 // IP as SNI. 18 // IP as SNI.
18 EXPECT_FALSE(CryptoUtils::IsValidSNI("192.168.0.1")); 19 EXPECT_FALSE(CryptoUtils::IsValidSNI("192.168.0.1"));
19 // SNI without any dot. 20 // SNI without any dot.
20 EXPECT_FALSE(CryptoUtils::IsValidSNI("somedomain")); 21 EXPECT_FALSE(CryptoUtils::IsValidSNI("somedomain"));
21 // Invalid RFC2396 hostname 22 // Invalid by RFC2396 but unfortunately domains of this form exist.
22 // TODO(rtenneti): Support RFC2396 hostname. 23 EXPECT_TRUE(CryptoUtils::IsValidSNI("some_domain.com"));
23 // EXPECT_FALSE(CryptoUtils::IsValidSNI("some_domain.com"));
24 // An empty string must be invalid otherwise the QUIC client will try sending 24 // An empty string must be invalid otherwise the QUIC client will try sending
25 // it. 25 // it.
26 EXPECT_FALSE(CryptoUtils::IsValidSNI("")); 26 EXPECT_FALSE(CryptoUtils::IsValidSNI(""));
27 27
28 // Valid SNI 28 // Valid SNI
29 EXPECT_TRUE(CryptoUtils::IsValidSNI("test.google.com")); 29 EXPECT_TRUE(CryptoUtils::IsValidSNI("test.google.com"));
30 } 30 }
31 31
32 TEST(CryptoUtilsTest, NormalizeHostname) { 32 TEST(CryptoUtilsTest, NormalizeHostname) {
33 struct { 33 struct {
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 CryptoUtils::HandshakeFailureReasonToString(MAX_FAILURE_REASON)); 186 CryptoUtils::HandshakeFailureReasonToString(MAX_FAILURE_REASON));
187 EXPECT_STREQ( 187 EXPECT_STREQ(
188 "INVALID_HANDSHAKE_FAILURE_REASON", 188 "INVALID_HANDSHAKE_FAILURE_REASON",
189 CryptoUtils::HandshakeFailureReasonToString( 189 CryptoUtils::HandshakeFailureReasonToString(
190 static_cast<HandshakeFailureReason>(MAX_FAILURE_REASON + 1))); 190 static_cast<HandshakeFailureReason>(MAX_FAILURE_REASON + 1)));
191 } 191 }
192 192
193 } // namespace 193 } // namespace
194 } // namespace test 194 } // namespace test
195 } // namespace net 195 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/core/crypto/crypto_utils.h ('k') | net/quic/core/crypto/curve25519_key_exchange_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698