Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: net/quic/core/crypto/quic_compressed_certs_cache_test.cc

Issue 2566783002: Various formatting cleanups to net/quic/crypto and net/quic/congestion_control (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/crypto/quic_compressed_certs_cache_test.cc
diff --git a/net/quic/core/crypto/quic_compressed_certs_cache_test.cc b/net/quic/core/crypto/quic_compressed_certs_cache_test.cc
index 456387e9bb65ac6305a8a3ed3c6514e54f10c882..0b61b95e93301ffaa2bbb3acb4bc153ab92791e3 100644
--- a/net/quic/core/crypto/quic_compressed_certs_cache_test.cc
+++ b/net/quic/core/crypto/quic_compressed_certs_cache_test.cc
@@ -11,6 +11,7 @@
#include "net/quic/test_tools/crypto_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
+using base::IntToString;
using std::string;
namespace net {
@@ -58,6 +59,8 @@ TEST_F(QuicCompressedCertsCacheTest, CacheMiss) {
chain, "mismatched common certs", cached_certs));
EXPECT_EQ(nullptr, certs_cache_.GetCompressedCert(chain, common_certs,
"mismatched cached certs"));
+
+ // A different chain though with equivalent certs should get a cache miss.
QuicReferenceCountedPointer<ProofSource::Chain> chain2(
new ProofSource::Chain(certs));
EXPECT_EQ(nullptr,
@@ -81,7 +84,7 @@ TEST_F(QuicCompressedCertsCacheTest, CacheMissDueToEviction) {
for (unsigned int i = 0;
i < QuicCompressedCertsCache::kQuicCompressedCertsCacheSize; i++) {
EXPECT_EQ(certs_cache_.Size(), i + 1);
- certs_cache_.Insert(chain, base::IntToString(i), "", base::IntToString(i));
+ certs_cache_.Insert(chain, IntToString(i), "", IntToString(i));
}
EXPECT_EQ(certs_cache_.MaxSize(), certs_cache_.Size());
« no previous file with comments | « net/quic/core/crypto/quic_compressed_certs_cache.h ('k') | net/quic/core/crypto/quic_crypto_client_config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698