Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2439493002: Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, dominickn+watch_chromium.org, skanuj+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, awdf+watch_chromium.org, grt+watch_chromium.org, rlp+watch_chromium.org, groby+spellwatch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, timvolodine, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, rouslan+spell_chromium.org, mlamouri+watch-permissions_chromium.org, Jered, donnd+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser Observer lists now support range-based for loops. BUG=655021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f Cr-Commit-Position: refs/heads/master@{#426745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -68 lines) Patch
M chrome/browser/engagement/site_engagement_service.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/lifetime/keep_alive_registry.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mdns.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/search/instant_service.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/task_manager/task_manager_interface.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M chrome/browser/win/enumerate_modules_model.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Eric Willigers
4 years, 2 months ago (2016-10-21 04:13:13 UTC) #8
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-21 04:34:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439493002/1
4 years, 2 months ago (2016-10-21 05:32:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 07:16:19 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:28:00 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f
Cr-Commit-Position: refs/heads/master@{#426745}

Powered by Google App Engine
This is Rietveld 408576698