Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: chrome/browser/task_manager/task_manager_interface.cc

Issue 2439493002: Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/task_manager/task_manager_interface.h" 5 #include "chrome/browser/task_manager/task_manager_interface.h"
6 6
7 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/task_manager/sampling/task_manager_impl.h" 8 #include "chrome/browser/task_manager/sampling/task_manager_impl.h"
9 #include "chrome/browser/task_manager/sampling/task_manager_io_thread_helper.h" 9 #include "chrome/browser/task_manager/sampling/task_manager_io_thread_helper.h"
10 #include "chrome/common/chrome_switches.h" 10 #include "chrome/common/chrome_switches.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 108
109 TaskManagerInterface::TaskManagerInterface() 109 TaskManagerInterface::TaskManagerInterface()
110 : refresh_timer_(new base::Timer(true, true)), 110 : refresh_timer_(new base::Timer(true, true)),
111 enabled_resources_flags_(0) { 111 enabled_resources_flags_(0) {
112 } 112 }
113 113
114 TaskManagerInterface::~TaskManagerInterface() { 114 TaskManagerInterface::~TaskManagerInterface() {
115 } 115 }
116 116
117 void TaskManagerInterface::NotifyObserversOnTaskAdded(TaskId id) { 117 void TaskManagerInterface::NotifyObserversOnTaskAdded(TaskId id) {
118 FOR_EACH_OBSERVER(TaskManagerObserver, observers_, OnTaskAdded(id)); 118 for (TaskManagerObserver& observer : observers_)
119 observer.OnTaskAdded(id);
119 } 120 }
120 121
121 void TaskManagerInterface::NotifyObserversOnTaskToBeRemoved(TaskId id) { 122 void TaskManagerInterface::NotifyObserversOnTaskToBeRemoved(TaskId id) {
122 FOR_EACH_OBSERVER(TaskManagerObserver, observers_, OnTaskToBeRemoved(id)); 123 for (TaskManagerObserver& observer : observers_)
124 observer.OnTaskToBeRemoved(id);
123 } 125 }
124 126
125 void TaskManagerInterface::NotifyObserversOnRefresh( 127 void TaskManagerInterface::NotifyObserversOnRefresh(
126 const TaskIdList& task_ids) { 128 const TaskIdList& task_ids) {
127 FOR_EACH_OBSERVER(TaskManagerObserver, 129 for (TaskManagerObserver& observer : observers_)
128 observers_, 130 observer.OnTasksRefreshed(task_ids);
129 OnTasksRefreshed(task_ids));
130 } 131 }
131 132
132 void TaskManagerInterface::NotifyObserversOnRefreshWithBackgroundCalculations( 133 void TaskManagerInterface::NotifyObserversOnRefreshWithBackgroundCalculations(
133 const TaskIdList& task_ids) { 134 const TaskIdList& task_ids) {
134 FOR_EACH_OBSERVER(TaskManagerObserver, 135 for (TaskManagerObserver& observer : observers_)
135 observers_, 136 observer.OnTasksRefreshedWithBackgroundCalculations(task_ids);
136 OnTasksRefreshedWithBackgroundCalculations(task_ids));
137 } 137 }
138 138
139 void TaskManagerInterface::NotifyObserversOnTaskUnresponsive(TaskId id) { 139 void TaskManagerInterface::NotifyObserversOnTaskUnresponsive(TaskId id) {
140 FOR_EACH_OBSERVER(TaskManagerObserver, observers_, OnTaskUnresponsive(id)); 140 for (TaskManagerObserver& observer : observers_)
141 observer.OnTaskUnresponsive(id);
141 } 142 }
142 143
143 base::TimeDelta TaskManagerInterface::GetCurrentRefreshTime() const { 144 base::TimeDelta TaskManagerInterface::GetCurrentRefreshTime() const {
144 return refresh_timer_->IsRunning() ? refresh_timer_->GetCurrentDelay() 145 return refresh_timer_->IsRunning() ? refresh_timer_->GetCurrentDelay()
145 : base::TimeDelta::Max(); 146 : base::TimeDelta::Max();
146 } 147 }
147 148
148 void TaskManagerInterface::ResourceFlagsAdded(int64_t flags) { 149 void TaskManagerInterface::ResourceFlagsAdded(int64_t flags) {
149 enabled_resources_flags_ |= flags; 150 enabled_resources_flags_ |= flags;
150 } 151 }
151 152
152 void TaskManagerInterface::SetEnabledResourceFlags(int64_t flags) { 153 void TaskManagerInterface::SetEnabledResourceFlags(int64_t flags) {
153 enabled_resources_flags_ = flags; 154 enabled_resources_flags_ = flags;
154 } 155 }
155 156
156 void TaskManagerInterface::ScheduleRefresh(base::TimeDelta refresh_time) { 157 void TaskManagerInterface::ScheduleRefresh(base::TimeDelta refresh_time) {
157 refresh_timer_->Start(FROM_HERE, 158 refresh_timer_->Start(FROM_HERE,
158 refresh_time, 159 refresh_time,
159 base::Bind(&TaskManagerInterface::Refresh, 160 base::Bind(&TaskManagerInterface::Refresh,
160 base::Unretained(this))); 161 base::Unretained(this)));
161 } 162 }
162 163
163 } // namespace task_manager 164 } // namespace task_manager
OLDNEW
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc ('k') | chrome/browser/win/enumerate_modules_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698