Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Side by Side Diff: chrome/browser/notifications/message_center_settings_controller.cc

Issue 2439493002: Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/notifications/message_center_settings_controller.h" 5 #include "chrome/browser/notifications/message_center_settings_controller.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 RebuildNotifierGroups(true); 310 RebuildNotifierGroups(true);
311 } 311 }
312 void MessageCenterSettingsController::OnProfileAuthInfoChanged( 312 void MessageCenterSettingsController::OnProfileAuthInfoChanged(
313 const base::FilePath& profile_path) { 313 const base::FilePath& profile_path) {
314 RebuildNotifierGroups(true); 314 RebuildNotifierGroups(true);
315 } 315 }
316 316
317 void MessageCenterSettingsController::OnIconImageUpdated( 317 void MessageCenterSettingsController::OnIconImageUpdated(
318 const message_center::NotifierId& id, 318 const message_center::NotifierId& id,
319 const gfx::Image& image) { 319 const gfx::Image& image) {
320 FOR_EACH_OBSERVER(message_center::NotifierSettingsObserver, observers_, 320 for (message_center::NotifierSettingsObserver& observer : observers_)
321 UpdateIconImage(id, image)); 321 observer.UpdateIconImage(id, image);
322 } 322 }
323 323
324 void MessageCenterSettingsController::OnNotifierEnabledChanged( 324 void MessageCenterSettingsController::OnNotifierEnabledChanged(
325 const message_center::NotifierId& id, 325 const message_center::NotifierId& id,
326 bool enabled) { 326 bool enabled) {
327 FOR_EACH_OBSERVER(message_center::NotifierSettingsObserver, observers_, 327 for (message_center::NotifierSettingsObserver& observer : observers_)
328 NotifierEnabledChanged(id, enabled)); 328 observer.NotifierEnabledChanged(id, enabled);
329 } 329 }
330 330
331 void MessageCenterSettingsController::DispatchNotifierGroupChanged() { 331 void MessageCenterSettingsController::DispatchNotifierGroupChanged() {
332 FOR_EACH_OBSERVER(message_center::NotifierSettingsObserver, observers_, 332 for (message_center::NotifierSettingsObserver& observer : observers_)
333 NotifierGroupChanged()); 333 observer.NotifierGroupChanged();
334 } 334 }
335 335
336 #if defined(OS_CHROMEOS) 336 #if defined(OS_CHROMEOS)
337 void MessageCenterSettingsController::CreateNotifierGroupForGuestLogin() { 337 void MessageCenterSettingsController::CreateNotifierGroupForGuestLogin() {
338 // Already created. 338 // Already created.
339 if (!notifier_groups_.empty()) 339 if (!notifier_groups_.empty())
340 return; 340 return;
341 341
342 user_manager::UserManager* user_manager = user_manager::UserManager::Get(); 342 user_manager::UserManager* user_manager = user_manager::UserManager::Get();
343 // |notifier_groups_| can be empty in login screen too. 343 // |notifier_groups_| can be empty in login screen too.
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 FROM_HERE, 409 FROM_HERE,
410 base::Bind( 410 base::Bind(
411 &MessageCenterSettingsController::CreateNotifierGroupForGuestLogin, 411 &MessageCenterSettingsController::CreateNotifierGroupForGuestLogin,
412 weak_factory_.GetWeakPtr())); 412 weak_factory_.GetWeakPtr()));
413 } 413 }
414 #endif 414 #endif
415 415
416 if (notify) 416 if (notify)
417 DispatchNotifierGroupChanged(); 417 DispatchNotifierGroupChanged();
418 } 418 }
OLDNEW
« no previous file with comments | « chrome/browser/memory/tab_manager.cc ('k') | chrome/browser/permissions/permission_request_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698