Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/browser/search/instant_service.cc

Issue 2439493002: Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/instant_service.cc
diff --git a/chrome/browser/search/instant_service.cc b/chrome/browser/search/instant_service.cc
index 62cb5fe9b4e84c7e94b83f0debd160cb110814f0..6fae88559ab93ad462506ef7f339b66548f8c369 100644
--- a/chrome/browser/search/instant_service.cc
+++ b/chrome/browser/search/instant_service.cc
@@ -199,8 +199,8 @@ void InstantService::UpdateThemeInfo() {
if (!theme_info_) {
OnThemeChanged();
} else {
- FOR_EACH_OBSERVER(InstantServiceObserver, observers_,
- ThemeInfoChanged(*theme_info_));
+ for (InstantServiceObserver& observer : observers_)
+ observer.ThemeInfoChanged(*theme_info_);
}
#endif // defined(ENABLE_THEMES)
}
@@ -280,8 +280,8 @@ void InstantService::OnMostVisitedItemsReceived(
}
void InstantService::NotifyAboutMostVisitedItems() {
- FOR_EACH_OBSERVER(InstantServiceObserver, observers_,
- MostVisitedItemsChanged(most_visited_items_));
+ for (InstantServiceObserver& observer : observers_)
+ observer.MostVisitedItemsChanged(most_visited_items_);
}
#if defined(ENABLE_THEMES)
@@ -400,8 +400,8 @@ void InstantService::OnThemeChanged() {
theme_provider.HasCustomImage(IDR_THEME_NTP_ATTRIBUTION);
}
- FOR_EACH_OBSERVER(InstantServiceObserver, observers_,
- ThemeInfoChanged(*theme_info_));
+ for (InstantServiceObserver& observer : observers_)
+ observer.ThemeInfoChanged(*theme_info_);
}
#endif // defined(ENABLE_THEMES)
@@ -432,9 +432,8 @@ void InstantService::OnTemplateURLServiceChanged() {
if (default_search_provider_changed || google_base_url_domain_changed) {
ResetInstantSearchPrerenderer();
- FOR_EACH_OBSERVER(
- InstantServiceObserver, observers_,
- DefaultSearchProviderChanged(google_base_url_domain_changed));
+ for (InstantServiceObserver& observer : observers_)
+ observer.DefaultSearchProviderChanged(google_base_url_domain_changed);
}
}
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | chrome/browser/spellchecker/spellcheck_custom_dictionary.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698