Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser

chrome/browser/engagement/site_engagement_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/engagement/site_engagement_service.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <utility>
@@ skipping 416 matching lines @@
     content::WebContents* web_contents,
     bool is_hidden) {
   const GURL& url = web_contents->GetVisibleURL();
   SiteEngagementMetrics::RecordEngagement(
       is_hidden ? SiteEngagementMetrics::ENGAGEMENT_MEDIA_HIDDEN
                 : SiteEngagementMetrics::ENGAGEMENT_MEDIA_VISIBLE);
   AddPoints(url, is_hidden ? SiteEngagementScore::GetHiddenMediaPoints()
                            : SiteEngagementScore::GetVisibleMediaPoints());
 
   RecordMetrics();
-  FOR_EACH_OBSERVER(
-      SiteEngagementObserver, observer_list_,
-      OnEngagementIncreased(web_contents, url, GetScore(url)));
+  for (SiteEngagementObserver& observer : observer_list_)
+    observer.OnEngagementIncreased(web_contents, url, GetScore(url));
 }
 
 void SiteEngagementService::HandleNavigation(content::WebContents* web_contents,
                                              ui::PageTransition transition) {
   if (IsEngagementNavigation(transition)) {
     const GURL& url = web_contents->GetLastCommittedURL();
     SiteEngagementMetrics::RecordEngagement(
         SiteEngagementMetrics::ENGAGEMENT_NAVIGATION);
     AddPoints(url, SiteEngagementScore::GetNavigationPoints());
 
     RecordMetrics();
-    FOR_EACH_OBSERVER(
-        SiteEngagementObserver, observer_list_,
-        OnEngagementIncreased(web_contents, url, GetScore(url)));
+    for (SiteEngagementObserver& observer : observer_list_)
+      observer.OnEngagementIncreased(web_contents, url, GetScore(url));
   }
 }
 
 void SiteEngagementService::HandleUserInput(
     content::WebContents* web_contents,
     SiteEngagementMetrics::EngagementType type) {
   const GURL& url = web_contents->GetVisibleURL();
   SiteEngagementMetrics::RecordEngagement(type);
   AddPoints(url, SiteEngagementScore::GetUserInputPoints());
 
   RecordMetrics();
-  FOR_EACH_OBSERVER(
-      SiteEngagementObserver, observer_list_,
-      OnEngagementIncreased(web_contents, url, GetScore(url)));
+  for (SiteEngagementObserver& observer : observer_list_)
+    observer.OnEngagementIncreased(web_contents, url, GetScore(url));
 }
 
 bool SiteEngagementService::IsLastEngagementStale() const {
   // This only happens when Chrome is first run and the user has never recorded
   // any engagement.
   base::Time last_engagement_time = GetLastEngagementTime();
   if (last_engagement_time.is_null())
     return false;
 
   return (clock_->Now() - last_engagement_time) >= GetStalePeriod();
@@ skipping 119 matching lines @@
     if (!engagement_score.last_shortcut_launch_time().is_null() &&
         engagement_score.last_shortcut_launch_time() > last_visit) {
       engagement_score.set_last_shortcut_launch_time(last_visit);
     }
 
     engagement_score.Commit();
   }
 
   SetLastEngagementTime(now);
 }