Improve GCM enum switch type safety

Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

Also converted two lists of == FOO || == BAR || == BAZ to switches
for the same reason.

And reordered a few switches to match the enums.

Should have no functional changes, except that GetConnectionResetReasonString can now stringify NEW_HEARTBEAT_INTERVAL (an enum value that had been omitted).

BUG=none

Committed: https://crrev.com/133bfbad6055349368a955d16318c1997d39810b
Cr-Commit-Position: refs/heads/master@{#426303}

[johnme, 2016-10-18 17:29:40]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 17:30:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[johnme, 2016-10-18 17:34:15]

Description was changed from

==========
Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

BUG=none
==========

to

==========
Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

Also converted two lists of == FOO || == BAR || == BAZ to switches
for the same reason.

And reordered a few switches to match the enums.

Should have no functional changes, except that GetConnectionResetReasonString
can now stringify NEW_HEARTBEAT_INTERVAL (an enum value that had been omitted).

BUG=none
==========

[commit-bot: I haz the power, 2016-10-18 17:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:40:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[johnme, 2016-10-19 18:21:07]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 18:21:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 20:16:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 20:16:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[johnme, 2016-10-19 20:24:30]

johnme@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2016-10-19 20:40:19]

lgtm

[johnme, 2016-10-19 21:07:35]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2016-10-19 21:08:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:14:18]

Description was changed from

==========
Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

Also converted two lists of == FOO || == BAR || == BAZ to switches
for the same reason.

And reordered a few switches to match the enums.

Should have no functional changes, except that GetConnectionResetReasonString
can now stringify NEW_HEARTBEAT_INTERVAL (an enum value that had been omitted).

BUG=none
==========

to

==========
Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

Also converted two lists of == FOO || == BAR || == BAZ to switches
for the same reason.

And reordered a few switches to match the enums.

Should have no functional changes, except that GetConnectionResetReasonString
can now stringify NEW_HEARTBEAT_INTERVAL (an enum value that had been omitted).

BUG=none
==========

[commit-bot: I haz the power, 2016-10-19 22:14:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:12:06]

Description was changed from

==========
Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

Also converted two lists of == FOO || == BAR || == BAZ to switches
for the same reason.

And reordered a few switches to match the enums.

Should have no functional changes, except that GetConnectionResetReasonString
can now stringify NEW_HEARTBEAT_INTERVAL (an enum value that had been omitted).

BUG=none
==========

to

==========
Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

Also converted two lists of == FOO || == BAR || == BAZ to switches
for the same reason.

And reordered a few switches to match the enums.

Should have no functional changes, except that GetConnectionResetReasonString
can now stringify NEW_HEARTBEAT_INTERVAL (an enum value that had been omitted).

BUG=none

Committed: https://crrev.com/133bfbad6055349368a955d16318c1997d39810b
Cr-Commit-Position: refs/heads/master@{#426303}
==========

[commit-bot: I haz the power, 2016-10-21 13:12:07]

Patchset 2 (id:??) landed as
https://crrev.com/133bfbad6055349368a955d16318c1997d39810b
Cr-Commit-Position: refs/heads/master@{#426303}

[johnme, 2016-11-03 18:09:06]

Cherry-picked to M55 in https://codereview.chromium.org/2473093002 as
f6af6a205a30cb5d3bc2f9682072c5df85b4660b 2883@{#437}