Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: google_apis/gcm/engine/account_mapping.cc

Issue 2427633005: Improve GCM enum switch type safety (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/instance_id/instance_id_impl.cc ('k') | google_apis/gcm/engine/checkin_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/account_mapping.cc
diff --git a/google_apis/gcm/engine/account_mapping.cc b/google_apis/gcm/engine/account_mapping.cc
index 411d177b76177a53c84351e29d19f4e1e3ab2642..12dbafa08421918cd36a66d872f68e748fc908eb 100644
--- a/google_apis/gcm/engine/account_mapping.cc
+++ b/google_apis/gcm/engine/account_mapping.cc
@@ -37,9 +37,8 @@ std::string StatusToString(AccountMapping::MappingStatus status) {
return kStatusMapped;
case AccountMapping::REMOVING:
return kStatusRemoving;
- default:
- NOTREACHED();
}
+ NOTREACHED();
return std::string();
}
« no previous file with comments | « components/gcm_driver/instance_id/instance_id_impl.cc ('k') | google_apis/gcm/engine/checkin_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698