Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: components/gcm_driver/gcm_desktop_utils.cc

Issue 2427633005: Improve GCM enum switch type safety (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_client_impl.cc ('k') | components/gcm_driver/gcm_stats_recorder_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_desktop_utils.cc
diff --git a/components/gcm_driver/gcm_desktop_utils.cc b/components/gcm_driver/gcm_desktop_utils.cc
index ce9994575a79ad946058bc54658407bcd23f7c35..ec566ead27f8788d9ea1d25bad12bb2587344bfa 100644
--- a/components/gcm_driver/gcm_desktop_utils.cc
+++ b/components/gcm_driver/gcm_desktop_utils.cc
@@ -53,10 +53,9 @@ GCMClient::ChromeChannel GetChannel(version_info::Channel channel) {
return GCMClient::CHANNEL_BETA;
case version_info::Channel::STABLE:
return GCMClient::CHANNEL_STABLE;
- default:
- NOTREACHED();
- return GCMClient::CHANNEL_UNKNOWN;
}
+ NOTREACHED();
+ return GCMClient::CHANNEL_UNKNOWN;
}
std::string GetVersion() {
« no previous file with comments | « components/gcm_driver/gcm_client_impl.cc ('k') | components/gcm_driver/gcm_stats_recorder_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698