GCM Registration: rename RESPONSE_PARSING_FAILED to NO_RESPONSE_BODY

GCM Registration: rename RESPONSE_PARSING_FAILED to NO_RESPONSE_BODY

The RegistrationRequest::RESPONSE_PARSING_FAILED enum value was
confusingly named, since it is actually logged only when there is no
body at all, not when parsing the body fails. Hence I'm renaming it to
NO_RESPONSE_BODY to match UnregistrationRequest::NO_RESPONSE_BODY.

BUG=none

Committed: https://crrev.com/f5ee18de1b2485a50255ab83968518b05ea2f359
Cr-Commit-Position: refs/heads/master@{#426608}

[johnme, 2016-10-20 12:47:16]

johnme@chromium.org changed reviewers:
+ isherman@chromium.org, zea@chromium.org

[johnme, 2016-10-20 12:47:16]

zea: please review overall patch
isherman: please review histograms. This is just renaming the bucket to make it
clearer what was actually being logged all along.
Thanks!

[johnme, 2016-10-20 12:47:23]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 12:47:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 12:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 12:58:21]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[johnme, 2016-10-20 15:39:21]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 15:39:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 18:15:15]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-10-20 19:26:09]

histograms.xml lgtm, thanks

[Nicolas Zea, 2016-10-20 21:06:02]

lgtm

[johnme, 2016-10-20 21:29:24]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2016-10-20 21:29:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 21:46:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:22:58]

Description was changed from

==========
GCM Registration: rename RESPONSE_PARSING_FAILED to NO_RESPONSE_BODY

The RegistrationRequest::RESPONSE_PARSING_FAILED enum value was
confusingly named, since it is actually logged only when there is no
body at all, not when parsing the body fails. Hence I'm renaming it to
NO_RESPONSE_BODY to match UnregistrationRequest::NO_RESPONSE_BODY.

BUG=none
==========

to

==========
GCM Registration: rename RESPONSE_PARSING_FAILED to NO_RESPONSE_BODY

The RegistrationRequest::RESPONSE_PARSING_FAILED enum value was
confusingly named, since it is actually logged only when there is no
body at all, not when parsing the body fails. Hence I'm renaming it to
NO_RESPONSE_BODY to match UnregistrationRequest::NO_RESPONSE_BODY.

BUG=none

Committed: https://crrev.com/f5ee18de1b2485a50255ab83968518b05ea2f359
Cr-Commit-Position: refs/heads/master@{#426608}
==========

[commit-bot: I haz the power, 2016-10-21 13:22:59]

Patchset 2 (id:??) landed as
https://crrev.com/f5ee18de1b2485a50255ab83968518b05ea2f359
Cr-Commit-Position: refs/heads/master@{#426608}

[johnme, 2016-11-03 18:10:39]

Cherry-picked to M55 in https://codereview.chromium.org/2479593004 as
e9a8fe09ec516334c759e9e1a952a98b797926fa 2883@{#438}