Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Unified Diff: google_apis/gcm/engine/checkin_request.cc

Issue 2427633005: Improve GCM enum switch type safety (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/engine/account_mapping.cc ('k') | google_apis/gcm/engine/connection_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/checkin_request.cc
diff --git a/google_apis/gcm/engine/checkin_request.cc b/google_apis/gcm/engine/checkin_request.cc
index 532069601f2ba7dcc6cf13ea09b5679f50545cf6..6e527ebe36c1ecb1ee10ab67a08d1e9a62ca95ba 100644
--- a/google_apis/gcm/engine/checkin_request.cc
+++ b/google_apis/gcm/engine/checkin_request.cc
@@ -58,10 +58,11 @@ std::string GetCheckinRequestStatusString(CheckinRequestStatus status) {
return "RESPONSE_PARSING_FAILED";
case ZERO_ID_OR_TOKEN:
return "ZERO_ID_OR_TOKEN";
- default:
+ case STATUS_COUNT:
NOTREACHED();
- return "UNKNOWN_STATUS";
+ break;
}
+ return "UNKNOWN_STATUS";
}
// Records checkin status to both stats recorder and reports to UMA.
« no previous file with comments | « google_apis/gcm/engine/account_mapping.cc ('k') | google_apis/gcm/engine/connection_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698