DescriptionWeb MIDI: MIDIInput/MIDIOutput should not have reference to MIDIAccess
Currently, MIDIOutput has a reference to MIDIAccess introducing a cyclic
reference between them. To avoid this issue, this change adopts a simple idea
to have a raw pointer to MIDIAccess from MIDIOutput and MIDIInput, and
internally has a reference to MIDIAccess in the v8 bindings.
This internal reference make MIDIAccess alive while MIDIOutput and MIDIInput
live. So, MIDIOutput and MIDIInput can assume the raw pointer is always
valid. Also the reference can be GCed in the v8 world.
BUG=163795
TEST=LayoutTests/webmidi
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157517
Patch Set 1 #Patch Set 2 : similarity=90 #Patch Set 3 : cleanup #Patch Set 4 : (rebase) #
Messages
Total messages: 15 (0 generated)
|