Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1506)

Unified Diff: Source/modules/webmidi/MIDIAccess.cpp

Issue 24070002: Web MIDI: MIDIInput/MIDIOutput should not have reference to MIDIAccess (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: (rebase) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8MIDIOutputCustom.cpp ('k') | Source/modules/webmidi/MIDIInput.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccess.cpp
diff --git a/Source/modules/webmidi/MIDIAccess.cpp b/Source/modules/webmidi/MIDIAccess.cpp
index 387993adb6d035df673882aa8fdd0a443a6040a5..8b45e928480b53c9c694fdd2e4b3d414242f0b2b 100644
--- a/Source/modules/webmidi/MIDIAccess.cpp
+++ b/Source/modules/webmidi/MIDIAccess.cpp
@@ -82,8 +82,7 @@ void MIDIAccess::didAddInputPort(const String& id, const String& manufacturer, c
{
ASSERT(isMainThread());
- // FIXME: Pass in |this| to create() method so we can filter system exclusive messages correctly.
- m_inputs.append(MIDIInput::create(scriptExecutionContext(), id, manufacturer, name, version));
+ m_inputs.append(MIDIInput::create(this, scriptExecutionContext(), id, manufacturer, name, version));
}
void MIDIAccess::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version)
« no previous file with comments | « Source/bindings/v8/custom/V8MIDIOutputCustom.cpp ('k') | Source/modules/webmidi/MIDIInput.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698